test(plotting): migrate fitted-model tests (#1328)#1361
Merged
Conversation
Final class of the image-test refactor. FittedModel.plot returns a Figure (return_fig=True), so the conf-int / cells knobs become real introspection. - Keep two visual baselines at STRICT_TOL: the plain precomputed-model plot and the confidence-band variant. - Introspection: `conf_int=True` draws a band iff the FittedModel carries conf-int data and is otherwise gracefully ignored (parametrized computed/not_computed); `hide_cells=False` adds the cell scatter. - Smoke (_assert_drawn): weights, the silently-ignored lineage_probability path, and FittedModel routed through gene_trends / cluster_trends / heatmap (those functions' rendering is already visually covered in their own classes; here we just assert the FittedModel path runs and draws). Delete 7 orphaned ground-truth figures (incl. the fitted_heatmap dir) and the old tol=250 cluster-fates knob. Full plotting suite: 311 passed, 7 skipped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final class of the #1328 image-test refactor.
FittedModel.plotreturns aFigure(return_fig=True), so the conf-int / cells knobs become real introspection.TestFittedModelconf_int=Truedraws a band iff the FittedModel carries conf-int data, otherwise gracefully ignored (parametrizedcomputed/not_computed— this replaces the old image test that asserted nothing);hide_cells=Falseadds the cell scatter._assert_drawn): weights, the silently-ignoredlineage_probabilitypath, and FittedModel routed throughgene_trends/cluster_trends/heatmap(those functions' rendering is already visually covered in their own classes — here we just assert the FittedModel path runs and draws non-blank).SignalAPI (_ms_signals); removes the oldtol=250cluster-fates knob and thefitted_heatmapbaseline dir.7 orphaned ground-truth figures deleted. Full plotting suite: 312 passed, 7 skipped.
With this, every plotting class is migrated — closing out #1328.
🤖 Generated with Claude Code