Conversation
Closed
Collaborator
* Minor version bump to 2.0.1 to allow new hackage upload
Diff.cabal declared cabal-version: 3.14 solely to use the new extra-files field for bundling Diff-liquidhaskell.cabal in the sdist. However, such version is not supported by Hackage and could break dependency solving for some comsumers. Switch to extra-source-files, which achieves the same sdist packaging with no functional difference for this use case, and drop cabal-version back to 1.18. This also requires switching the license field from the SPDX identifier BSD-3-Clause back to the legacy BSD3, since SPDX license expressions aren't recognized before cabal-version: 2.2.
Collaborator
|
We just saw https://hackage.haskell.org/package/Diff-2.0.0/reports/2 reporting: #48 stacks such changes onto this PR |
Lower cabal-version back to 1.18
ninioArtillero
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to Xavier Góngora and Facundo Domínguez who have put some real polish on this package. This version has significant performance optimizations (see PR #25, #30 and #37, leading to a ~2.4x and ~8.5x getDiff improvement on benchmarks) and removes groupBy' from the API (see #26.)