Skip to content

Lower cabal-version back to 1.18 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddssff merged 1 commit into from
Sep 6, 2026
Merged

Lower cabal-version back to 1.18 #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Diff-liquidhaskell/Diff-liquidhaskell.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cabal-version: 2.4
cabal-version: 1.18
name: Diff-liquidhaskell
version: 0.1.0.0
synopsis: LiquidHaskell static checks for the Diff package
Expand Down Expand Up @@ -30,7 +30,7 @@ library
-- LH version scheme: 0.<GHC_VERSION>.<LH_REVISION>
-- Update the corresponding versions in .github/workflows/liquidhaskell.yml
-- after upgrading GHC and LH to keep CI in sync.
, liquidhaskell ^>= 0.9.14.1.1
, liquidhaskell ==0.9.14.1.1
-- Recompilation check is disabled to make sure changes to specification
-- annotations are checked by the LH plugin (otherwise they are silently ignored
-- if no source change is introduced).
Expand Down
6 changes: 3 additions & 3 deletions Diff.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Cabal-Version: 3.14
Cabal-Version: 1.18

@Bodigrim Bodigrim Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is little point of going all the way to 1.18, clients with Cabal < 2.0 are not served by modern Hackage server. So even very conservatively you can use 2.0, but practically I'd put 3.10, which is the version of Cabal at Hackage build machine (https://github.com/haskell-infra/hackage-doc-builder-config/blob/master/flake.lock).

@ddssff ddssff Sep 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I've been jumping the gun. I will continue making minor version changes.

@ninioArtillero ninioArtillero Sep 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can keep it like this (changes are already merged), and make a bump to 3.14 (so that the originally proposed extra-files field can be used) once that is supported.

BTW, is the spec version used by the Hackage server the effective upper-bound for supported versions?

Also, it is not clear to me what reasons could we have to be conservative about this version number. Wouldn't some consumers be affected by bumping to 3.10? Are there existing documentation on best practices?

@Bodigrim Bodigrim Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, is the spec version used by the Hackage server the effective upper-bound for supported versions?

Hackage server itself at the moment uses Cabal-the-library 3.16 (you can see it in the footer of any package page such as https://hackage.haskell.org/package/Diff), so the original 3.14 was absolutely fine. If it was too new, Hackage would simply reject the upload as unparseable. It's the documentation build server which lags behind at the moment and still uses Cabal-the-executable 3.10. So to be honest I would not revert anything in the first place, just uploaded the documentation manually and leave it be; at some point the doc builder will be upgraded.

Wouldn't some consumers be affected by bumping to 3.10?

If consumers are using Cabal-the-executable 3.8 (which is 5 major versions behind the last release of 3.18), I imagine they are not exactly looking to upgrade Diff to the latest and greatest.

No active harm in having cabal-version: 1.18, so I would not do another minor release for now.

name: Diff
version: 2.0.1
synopsis: Diff algorithm in pure Haskell
Expand All @@ -8,13 +8,13 @@ description: Implementation of the standard diff algorithm in Haskell.
Space complexity is O(D^2). Includes utilities for pretty printing.
category: Algorithms
homepage: https://web.archive.org/web/20150326181224/http://citeseerx.ist.psu.edu/viewdoc/summary?doi=10.1.1.4.6927
license: BSD-3-Clause
license: BSD3
license-file: LICENSE
author: Sterling Clover
maintainer: David Fox <dsf@seereason.com>
build-Type: Simple
extra-doc-files: README.md, CHANGELOG.md
extra-files: ./Diff-liquidhaskell/Diff-liquidhaskell.cabal
extra-source-files: ./Diff-liquidhaskell/Diff-liquidhaskell.cabal
bug-reports: https://github.com/seereason/Diff/issues

tested-with:
Expand Down