STRATCONN-6833 - [Customerio] - msresponse support#3816
Open
joe-ayoub-segment wants to merge 6 commits into
Open
STRATCONN-6833 - [Customerio] - msresponse support#3816joe-ayoub-segment wants to merge 6 commits into
joe-ayoub-segment wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Customer.io Track API batch multi-status response support so batch-level responses can be converted into per-item success/error results for the Actions framework.
Changes:
- Updates
sendBatchto await Customer.io batch responses and returnMultiStatusResponse. - Adds Customer.io batch response/error types and a
parseResponsehelper. - Adds unit coverage for batch MSR parsing/error handling and additional timestamp conversion cases.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/destination-actions/src/destinations/customerio/utils.ts |
Implements MSR parsing and error conversion for Customer.io batch requests. |
packages/destination-actions/src/destinations/customerio/types.ts |
Adds Track API batch response/error type definitions. |
packages/destination-actions/src/destinations/customerio/__tests__/utils.test.ts |
Adds tests for MSR behavior and timestamp conversion edge cases. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds multi-status response (MSR) support to the Customer.io destination's batch endpoint, converting per-item successes and errors from the Track API into the framework's MultiStatusResponse format
New unit tests
utils.test.ts — sendBatch describe block (all new):
utils.test.ts — parseResponse describe block (all new):
utils.test.ts — convertValidTimestamp (new cases added to existing test):
createUpdateObject.test.ts — performBatch describe block (all new):
Manual testing - completed by Customer.io team
Verify that when the Track API returns partial errors, the correct items are marked as failed and the successful items at their original positions are reported as successes.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example