[PINT-2637] - Several new features by jumpingGrendel · Pull Request #3826 · segmentio/action-destinations

jumpingGrendel · 2026-06-07T15:40:28Z

Add channel_id + channel_type as optional audience selectors across customEvents, setAttributes, and manageTags; channel_type is optional and defaults to the generic channel key (Airship resolves the type server-side); also fixes endpoint routing so both selector types correctly use /api/channels/attributes and /api/channels/tags
Support objects and arrays as attribute values in setAttributes; JSON attribute keys are automatically suffixed with #default as the instance ID when one isn't already supplied (Airship's required key format for JSON attributes)
Customize User-Agent header to outgoing requests for attribution in Airship-side logging

Testing

Added unit tests for new functionality
Tested end-to-end using the local server
[If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
[Segmenters] Tested in the staging environment
[Segmenters] [If applicable for this change] Tested for regression with Hadron.

Security Review

Please ensure sensitive data is properly protected in your integration.

Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

New Destination Checklist

Extracted all action API versions to verioning-info.ts file. example

joe-ayoub-segment · 2026-06-18T09:41:20Z

        Accept: 'application/vnd.urbanairship+json; version=3',
-        'Content-Type': 'application/json'
+        'Content-Type': 'application/json',
+        'User-Agent': `PartnerIntegrations/Segment (${settings.app_key})`


Hi @jumpingGrendel can you include this new header in a unit test please? Just want to make sure it's completely deliberate.

joe-ayoub-segment · 2026-06-18T09:43:16Z

Hi @jumpingGrendel
I reviewed the PR and added some comments and a couple of minor requests. But overall it looks good to me!
Are you able to attach proof of testing (a couple of screenshots) to the PR description please?
Best regards,
Joe

…tently — maps ios/android/amazon/web → *_channel, falls back to generic channel when omitted/unrecognized * gave channel_type a default: $.context.device.type and kept it a free string * added a User-Agent header unit test * added batch test for customEvents (was missing) * dropped the BROWSER/serve.ts commit * commented index.ts env-var defaults

jumpingGrendel · 2026-06-21T16:47:00Z

Hi @jumpingGrendel I reviewed the PR and added some comments and a couple of minor requests. But overall it looks good to me! Are you able to attach proof of testing (a couple of screenshots) to the PR description please? Best regards, Joe

Hello @joe-ayoub-segment thanks for the review. I removed the change to serve (I hope Segment will consider adding this!) as well as the default env-vars as per your requests. I don't want to make channel_type an enum because

the assumption is, if a customer has access to the channel id, chances are they have access to the type in the precise format needed (via the source integration)
it will fall back to generic channel if it is missing or doesn't match
I gave it a default mapping

I added a unit test for the userAgent change, as well as a couple other test updates, as well as a bit of refactoring to make it make a bit more sense. Also, bunch of screenshots of the testing. I hope that covers it!

joe-ayoub-segment · 2026-07-01T12:52:58Z

Thanks @jumpingGrendel looks good to me. You forgot to add the proof of testing screenshots though. Can you add them please? I'll then approve the PR.

jumpingGrendel · 2026-07-01T16:20:10Z

@joe-ayoub-segment that's so weird, they must've been stripped out when I edited the description to include them.

jumpingGrendel added 2 commits June 5, 2026 16:13

Add app key to userAgent

69e40f4

support sending json attributes

2a8d6ca

jumpingGrendel requested a review from a team as a code owner June 7, 2026 15:40

joe-ayoub-segment self-assigned this Jun 8, 2026

joe-ayoub-segment added the partner-eng-review (cloud) label Jun 8, 2026