Skip to content

Conversation

@codchen
Copy link
Collaborator

@codchen codchen commented Nov 10, 2025

Describe your changes and provide context

Flatten call stack of EndBlock

Testing performed to validate your change

unit test

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 11, 2025, 3:33 AM

@github-actions
Copy link

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 10, 2025, 5:40 AM

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 16.23932% with 98 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.32%. Comparing base (fe95a1f) to head (f0dd230).

Files with missing lines Patch % Lines
x/evm/keeper/abci.go 0.00% 75 Missing ⚠️
app/legacyabci/end_block.go 0.00% 8 Missing ⚠️
sei-cosmos/x/accesscontrol/keeper/abci.go 0.00% 8 Missing ⚠️
app/legacyabci/begin_block.go 0.00% 4 Missing ⚠️
app/apptesting/test_suite.go 0.00% 1 Missing ⚠️
app/test_helpers.go 0.00% 1 Missing ⚠️
x/epoch/keeper/abci.go 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (16.23%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2540      +/-   ##
==========================================
- Coverage   43.37%   43.32%   -0.05%     
==========================================
  Files        1576     1578       +2     
  Lines      137816   137767      -49     
==========================================
- Hits        59775    59694      -81     
- Misses      72622    72654      +32     
  Partials     5419     5419              
Flag Coverage Δ
sei-chain 31.12% <16.66%> (-0.14%) ⬇️
sei-cosmos 52.53% <0.00%> (-0.02%) ⬇️
sei-db 47.60% <ø> (ø)
sei-tendermint 48.80% <ø> (+0.06%) ⬆️
sei-wasmd 46.12% <57.14%> (-0.15%) ⬇️
sei-wasmvm 40.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/abci.go 62.29% <100.00%> (+5.69%) ⬆️
app/app.go 72.30% <100.00%> (-1.00%) ⬇️
sei-cosmos/types/module/module.go 51.75% <ø> (-3.01%) ⬇️
sei-cosmos/x/accesscontrol/module.go 0.00% <ø> (ø)
sei-cosmos/x/crisis/module.go 3.33% <ø> (+0.15%) ⬆️
sei-cosmos/x/feegrant/module/module.go 0.00% <ø> (ø)
sei-cosmos/x/gov/module.go 50.00% <ø> (-1.86%) ⬇️
sei-cosmos/x/staking/module.go 54.68% <ø> (-1.38%) ⬇️
sei-wasmd/x/wasm/module.go 40.00% <ø> (-1.18%) ⬇️
x/epoch/module.go 69.35% <ø> (-0.96%) ⬇️
... and 11 more

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

k.RemoveFirstNTxHashes(ctx, DefaultTxHashesToRemove)

// Migrate legacy EVM receipts to receipt.db in small batches every N blocks
if ctx.BlockHeight()%LegacyReceiptMigrationInterval == 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is not needed any more, @jewei1997 can you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants