-
Notifications
You must be signed in to change notification settings - Fork 857
Streamline EndBlock #2540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Streamline EndBlock #2540
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (16.23%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2540 +/- ##
==========================================
- Coverage 43.37% 43.32% -0.05%
==========================================
Files 1576 1578 +2
Lines 137816 137767 -49
==========================================
- Hits 59775 59694 -81
- Misses 72622 72654 +32
Partials 5419 5419
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
0ca8b94 to
f0dd230
Compare
| k.RemoveFirstNTxHashes(ctx, DefaultTxHashesToRemove) | ||
|
|
||
| // Migrate legacy EVM receipts to receipt.db in small batches every N blocks | ||
| if ctx.BlockHeight()%LegacyReceiptMigrationInterval == 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is not needed any more, @jewei1997 can you confirm?
Describe your changes and provide context
Flatten call stack of EndBlock
Testing performed to validate your change
unit test