Implement workflow system for semaphore ui #3487
Conversation
Co-authored-by: denguk <[email protected]>
|
Cursor Agent can help with this pull request. Just |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| links, err := e.store.GetWorkflowLinks(workflow.ProjectID, workflow.ID) | ||
| if err != nil { log.Error(err); return } | ||
|
|
||
| nodes, err := e.store.GetWorkflowNodes(workflow.ProjectID, workflow.ID) |
| // But triggering creates new running nodes. | ||
| // So we check active nodes count. | ||
|
|
||
| activeNodeRuns, err := e.store.GetWorkflowNodeRuns(workflow.ProjectID, runID) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Fetch projectID from workflow via run | ||
| run, err := e.store.GetWorkflowRun(0, runID) | ||
| if err != nil { | ||
| log.Error("Failed to get workflow run", err) | ||
| e.failNodeRun(newNodeRun, "Failed to get workflow run") |
There was a problem hiding this comment.
In triggerNode the workflow run is loaded with GetWorkflowRun(0, runID), but the SQL for that method joins workflow_run against workflow on the provided project ID. Passing 0 means the lookup always returns “not found”, so every task node immediately logs “Failed to get workflow run”, is marked as error, and no tasks are ever queued for execution. The engine needs to pass the real project ID (from the workflow or run) to allow workflows to run at all.
Useful? React with 👍 / 👎.
GEMINI 3
Implement Workflow feature to allow chaining tasks into pipelines with conditional and parallel execution.
This PR introduces the core components for the Workflow system: