feat: add support for python3.12 and 3.13#1087
feat: add support for python3.12 and 3.13#1087tiwarishubham635 merged 9 commits intosendgrid:mainfrom
Conversation
|
@tiwarishubham635 I don't have permission to assign a reviewer to the PR. |
|
@tiwarishubham635 any updates on this? |
| virtualenv --python=python venv | ||
|
|
||
| install: venv | ||
| . venv/bin/activate; pip install -r test/requirements.txt |
There was a problem hiding this comment.
Can you tell me why do we need to change the makefile? I think we can skip this
|
This looks good to me, just we can skip the Makefile change I feel. Also, can you add support for python 3.13 as well, else I'll have to raise a separate PR. |
| strategy: | ||
| matrix: | ||
| python-version: [ '2.7', '3.5', '3.6', '3.7', '3.8', '3.9', '3.10', '3.11' ] | ||
| python-version: [ '2.7', '3.5', '3.6', '3.7', '3.8', '3.9', '3.10', '3.11', '3.12' ] |
There was a problem hiding this comment.
Can you add 3.13 here as well?
|
This pull request has been around for a year now. For additional required changes, maintainers have access to modify the contents of this pull request. 👇 Cheers. 🥂 |
Thanks for this @meysam81! I have made the changes. One last thing before merging this. Is there any specific reason why we are adding setuptools to our requirements.txt? |
|
Yes, this is the reason 👇
|



Python3.12
fixes #1086
Checklist