chore: update ecdsa in setup.py#1102
Conversation
|
@shrutiburman @tiwarishubham635 Why do we maintain dependencies in two different files (requirements.txt and setup.py) files? Any reason to keep the same dependencies duplicated in both (can setup.py read the dependencies from the requirements file and use it internally) ? |
|
Hi @ranjanprasad1996! Setup.py is something which is a must for distributable packages and libraries like ours. Thus it is something which we must have. i don't think it reads from the requirements.txt. I can check for the possibility of omission of the later one. Thanks! |
|
@tiwarishubham635 I understand that it is required for distributable packages. What i am suggesting is having all dependencies in one place (requirements.txt) and setup.py script can read from the file and use it internally |
|
I totally understand that, let me check if we can do this in some way. Thanks for pointing this out |
Fixes #1101
Following up on #1085, adding ecdsa in setup.py as well
Checklist
If you have questions, please file a support ticket.