Skip to content

pin nokogiri version and remove support for ruby-2.3 #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

pin nokogiri version and remove support for ruby-2.3 #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a27bda
pin nokogiri version
phumpal Jan 6, 2021
6f0fe87
Remove support for deprecated ruby version 2.3.x
phumpal Jan 6, 2021
476f05b
Update changelog
phumpal Jan 6, 2021
bd053bd
ovirt-engine-sdk now requires pinning
phumpal Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ before_install:
install:
- bundle install
rvm:
- 2.3.0
- 2.4.1
notifications:
email:
Expand All @@ -29,7 +28,6 @@ deploy:
on:
tags: true
all_branches: true
rvm: 2.3.0
rvm: 2.4.1
repo: sensu-plugins/sensu-plugins-aws
- provider: script
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).
This CHANGELOG follows the format listed [here](https://github.com/sensu-plugins/community/blob/master/HOW_WE_CHANGELOG.md)

## [Unreleased]
### Fixed
- `sensu-plugins-aws.gemspec` pin nokogiri version to allow custom installs (@phumpal)
### Changed
- `sensu-plugins-aws.gemspec` and `travis.yml` remove deprecated ruby-2.3 (@phumpal)

### Added
- `check-subnet-ip-consumption.rb` - Added `--warn-only` option (@ChrisCalavera)
Expand Down
5 changes: 3 additions & 2 deletions sensu-plugins-aws.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Gem::Specification.new do |s| # rubocop:disable Metrics/BlockLength
s.platform = Gem::Platform::RUBY
s.post_install_message = 'You can use the embedded Ruby by setting EMBEDDED_RUBY=true in /etc/default/sensu'
s.require_paths = ['lib']
s.required_ruby_version = '>= 2.3.0'
s.required_ruby_version = '>= 2.4.1'
s.summary = 'Sensu plugins for working with an AWS environment'
s.test_files = s.files.grep(%r{^(test|spec|features)/})
s.version = SensuPluginsAWS::Version::VER_STRING
Expand All @@ -39,7 +39,8 @@ Gem::Specification.new do |s| # rubocop:disable Metrics/BlockLength
# 1.44 requires xmlrpc which only supports >= ruby 2.3
# https://github.com/fog/fog-core/issues/206
s.add_runtime_dependency 'fog-core', '1.45.0'
s.add_runtime_dependency 'nokogiri', ['>= 1.10.4', '< 2.0']
s.add_runtime_dependency 'nokogiri', '1.10.10'
s.add_runtime_dependency 'ovirt-engine-sdk', '4.3.1'
s.add_runtime_dependency 'rest-client', '2.1.0'
s.add_runtime_dependency 'right_aws', '3.1.0'

Expand Down