fix: use after move

include/seqan3/alignment/pairwise/edit_distance_algorithm.hpp

@@ -91,10 +91,7 @@ class edit_distance_algorithm
         using std::get;
 
         for (auto && [sequence_pair, index] : indexed_sequence_pairs)
-            compute_single_pair(index,
-                                get<0>(sequence_pair),
-                                get<1>(sequence_pair),
-                                std::forward<callback_t>(callback));
+            compute_single_pair(index, get<0>(sequence_pair), get<1>(sequence_pair), callback);
     }
 
 private:

include/seqan3/search/detail/policy_search_result_builder.hpp

@@ -151,7 +151,7 @@ struct policy_search_result_builder
                 search_result_type result{};
 
                 if constexpr (search_traits_type::output_query_id)
-                    result.query_id_ = std::move(idx);
+                    result.query_id_ = idx;
                 if constexpr (search_traits_type::output_index_cursor)
                     result.cursor_ = cursor;
                 if constexpr (search_traits_type::output_reference_id)

include/seqan3/search/views/minimiser.hpp

@@ -273,9 +273,9 @@ class minimiser_view<urng1_t, urng2_t>::basic_iterator
 
     /*!\brief Construct from begin and end iterators of a given range over std::totally_ordered values, and the number
               of values per window.
-    * \param[in] urng1_iterator Iterator pointing to the first position of the first std::totally_ordered range.
-    * \param[in] urng1_sentinel Iterator pointing to the last position of the first std::totally_ordered range.
-    * \param[in] urng2_iterator Iterator pointing to the first position of the second std::totally_ordered range.
+    * \param[in] urng1_iterator_ Iterator pointing to the first position of the first std::totally_ordered range.
+    * \param[in] urng1_sentinel_ Iterator pointing to the last position of the first std::totally_ordered range.
+    * \param[in] urng2_iterator_ Iterator pointing to the first position of the second std::totally_ordered range.
     * \param[in] window_size The number of values in one window.
     *
     * \details
@@ -284,13 +284,13 @@ class minimiser_view<urng1_t, urng2_t>::basic_iterator
     * shifts then by one to repeat this action. If a minimiser in consecutive windows is the same, it is returned only
     * once.
     */
-    basic_iterator(urng1_iterator_t urng1_iterator,
-                   urng1_sentinel_t urng1_sentinel,
-                   urng2_iterator_t urng2_iterator,
+    basic_iterator(urng1_iterator_t urng1_iterator_,
+                   urng1_sentinel_t urng1_sentinel_,
+                   urng2_iterator_t urng2_iterator_,
                    size_t window_size) :
-        urng1_iterator{std::move(urng1_iterator)},
-        urng1_sentinel{std::move(urng1_sentinel)},
-        urng2_iterator{std::move(urng2_iterator)}
+        urng1_iterator{std::move(urng1_iterator_)},
+        urng1_sentinel{std::move(urng1_sentinel_)},
+        urng2_iterator{std::move(urng2_iterator_)}
     {
         size_t size = std::ranges::distance(urng1_iterator, urng1_sentinel);
         window_size = std::min<size_t>(window_size, size);

include/seqan3/search/views/minimiser_hash.hpp

@@ -85,7 +85,7 @@ struct minimiser_hash_fn
         if (shape.size() > window_size.get())
             throw std::invalid_argument{"The size of the shape cannot be greater than the window size."};
 
-        auto forward_strand = std::forward<urng_t>(urange) | seqan3::views::kmer_hash(shape)
+        auto forward_strand = urange | seqan3::views::kmer_hash(shape)
                             | std::views::transform(
                                   [seed](uint64_t i)
                                   {