feat: Metrics tracking for network management#404
Open
Tw1ZZLER wants to merge 159 commits into
Open
Conversation
I don't know if 2 Timelines will ever exist at once, but if so then this might be a problem. For now it seems to be an okay solution
This reverts commit d7ede60.
Collaborator
Author
|
Ready for review just gonna add a few more |
Tw1ZZLER
marked this pull request as ready for review
July 23, 2026 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new EventTypes
RESERVATION_APPROVED,RESERVATION_REJECTED, andRESERVATION_COMPLETION, as well asTHROUGHPUTfor the modified throughput metric. Throughput and reservation start time have been removed from the minimizedCollectContext(that we are trying to do away with altogether) and are now based on existing metrics. It is worth noting that the collect method ofRateMetrichas been adjusted to quite literally copy and completely replaceRequestApp.get_throughput(). It has also been renamed toThroughputMetricas result.