Fix legacy Dockerfile syntax flagged by BuildKit - #161
Merged
Conversation
- 'FROM ... as build' -> 'AS' (FromAsCasing) - 'ENV key value' -> 'ENV key=value' for USE_SINGLE_BUILDDIR and BOOST_DEBUG (LegacyKeyValueFormat) No functional change; 'docker build --check' now reports no warnings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker build --checkreported 3 deprecation warnings on the Dockerfile. This resolves them with no functional change:FROM ubuntu:26.04 as build→AS build— FromAsCasingENV USE_SINGLE_BUILDDIR 1→ENV USE_SINGLE_BUILDDIR=1— LegacyKeyValueFormatENV BOOST_DEBUG 1→ENV BOOST_DEBUG=1— sameVerification
docker build --checknow reports no warnings. The space- and=-forms of single-valueENVare semantically identical andas/ASis purely casing, so the build is unaffected.Other repos
Checked all four with
docker build --check; monerod, docker-bitcoind, and monero-wallet-rpc are already clean — p2pool was the only one with legacy syntax.🤖 Generated with Claude Code