fix: project offline state into vocab space #297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #293 introduces new behavior which saves only the last layer hidden states from the target model when generating offline hidden states. This saves us from needing to load the entire vocab size of logits into CPU RAM.
This breaks the old
OfflineEagle3Modelclass which passestargettoOnlineEagle3Modelwithout projecting the shape fromhidden_sizetovocab_size.Modifications
Project the offline hidden state into the correct shape using the target LM head in
OfflineEagle3Model.forward().Related Issues
Accuracy Test
Benchmark & Profiling
Checklist