Skip to content

Restructure MoE and Add MoE prepare input kernels #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Restructure MoE and Add MoE prepare input kernels #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bab489e
Restructure MoE and add prepare inputs/meta kernel
kareemshaik80 Oct 30, 2025
d5e78ac
fix minor issues
kareemshaik80 Oct 30, 2025
651c0f6
Add tests
kareemshaik80 Nov 3, 2025
328d63a
Add shuffle_rows Kernel
kareemshaik80 Nov 4, 2025
efb105f
register shuffle_rows
kareemshaik80 Nov 4, 2025
d849b61
Enable Build and Add apply_shuffle_mul_sum kernel
kareemshaik80 Nov 7, 2025
f2f1577
functional
kareemshaik80 Nov 10, 2025
33fe2ed
cleanup
kareemshaik80 Nov 10, 2025
8944fbc
cleanup1
kareemshaik80 Nov 10, 2025
1be44d6
Merge branch 'sgl-project:main' into main
kareemshaik80 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# ATen XPU sources

file(GLOB device_cpp "sycl/*.cpp" "sycl/*.sycl")
file(GLOB device_cpp "sycl/*.cpp" "sycl/*.sycl" "sycl/kernels/moe/*.cpp")
file(GLOB host_cpp "./*.cpp" "./*.cc")

list(APPEND ATen_XPU_CPP_SRCS ${host_cpp})
Expand Down
7 changes: 4 additions & 3 deletions src/sycl/TripleOps.cpp → src/sycl/kernels/moe/activations.cpp
View file
Open in desktop
Copy link
Collaborator

@airMeng airMeng Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

activations not only serve for MoE, better leave it unchanged.
Beside I'd prefer only put customized cutlass code under src/sycl/kernels/, and leave pure SYCL code outside

Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
#include <sycl/sycl.hpp>
#include <vector>

#include "MemoryAccess.h"
#include "SYCLHelpers.h"
#include "Utils.h"
#include "../../MemoryAccess.h"
#include "../../SYCLHelpers.h"
#include "../../Utils.h"

#define DPCPP_CONSTANT __attribute__((opencl_constant))

Expand Down Expand Up @@ -232,3 +232,4 @@ void gelu_and_mul(at::Tensor& out, at::Tensor& input) {
}
return;
}

Loading