Added support for cutlass_mla_get_workspace_size (with new execution engine interface) #36
+1,098
−858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pralay-das
force-pushed
the
dev/pralay/cutlass_mla_get_workspace_size
branch
from
ab5e654 to
cf3362a
Compare
pralay-das
force-pushed
the
dev/pralay/cutlass_mla_get_workspace_size
branch
from
cf3362a to
f5dde3b
Compare
| // need to change these parameters to match the actual use case | ||
| // will do later | ||
|
|
||
| return MlaFlashAttnType::Kernel::get_workspace_size(arguments); |
There was a problem hiding this comment.
Do you have specific WS sizes for mla, this is returning zero size. Or do we really need this API for our implementation?
Author
There was a problem hiding this comment.
hi, I don't have any specific WS sizes right now, which can work for both mla and chunked_prefill...
I have seen in the test case it is calling this function before calling mla function, and simple returning zero is working fine with the test case...
There was a problem hiding this comment.
right, let's come up with right sizes for different configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
cmd:
python -m pytest tests/test_flash_attention.pyresult:
96 passed, 182 skipped, 1 warning in 3.43s