-
Notifications
You must be signed in to change notification settings - Fork 33
feat: support structured output #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support structured output #354
Conversation
Summary of ChangesHello @jimoosciuc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant feature to support structured output generation, addressing the need for reliable and machine-parseable responses from language models. By integrating grammar-constrained decoding, the system can now enforce specific output formats like JSON, regex, or EBNF, which helps in reducing hallucinations and ensuring valid data structures for APIs, automations, and UI forms. The changes span across the core sampling logic, scheduler, and API entrypoints, with a focus on JAX/TPU compatibility and efficient vocabulary masking. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
92da5ee to
3b0402b
Compare
3b0402b to
7ef752b
Compare
|
Hi, @jimoosciuc . I think we need to abort requests in grammar queue when calling |
7ef752b to
d667eaf
Compare
nice catch! |
d667eaf to
a2b7f3b
Compare
CLOSES: #331
Motivation
Modifications
Accuracy Tests
Launch Server:
Result:


gsm8k (bsz=128)
mmlu (bsz=128)
Benchmarking and Profiling
testing methodology reference: qwen3_benchmark
Launch Server:
Result:
Test command
e2e test
unit test
Checklist