Add GTK 4 variant of Greybird-dark by mathiascode · Pull Request #341 · shimmerproject/Greybird

mathiascode · 2023-09-09T13:02:03Z

Fixes https://forum.xfce.org/viewtopic.php?pid=73009

houndci-bot · 2023-09-09T13:02:10Z

@@ -0,0 +1 @@
+../../light/gtk-4.0/Gemfile


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2023-09-09T13:02:11Z

@@ -0,0 +1 @@
+../../light/gtk-4.0/_common.scss


Commas in function parameters should be followed by one space

houndci-bot · 2023-09-09T13:02:11Z

@@ -0,0 +1 @@
+../../light/gtk-4.0/gtk-contained-dark.scss


Prefer double-quoted strings

houndci-bot · 2023-09-09T13:02:11Z

@@ -0,0 +1 @@
+../../light/gtk-4.0/gtk-dark.scss


Prefer double-quoted strings

houndci-bot · 2023-09-09T13:02:11Z

@@ -0,0 +1 @@
+../../light/gtk-4.0/gtk.scss


Prefer double-quoted strings

rozhuk-im · 2023-09-25T23:31:59Z

Thanks, but fail to build:

...
[  9% 10/11] /usr/local/bin/glib-compile-resources ../dark/gtk-4.0/gtk.gresource.xml --target dark/gtk-4.0/gtk.gresource --sourcedir /tmp/ports/usr/ports/x11-themes/greybird-theme/work/Greybird-3.23.3/dark/gtk-4.0
FAILED: dark/gtk-4.0/gtk.gresource 
/usr/local/bin/glib-compile-resources ../dark/gtk-4.0/gtk.gresource.xml --target dark/gtk-4.0/gtk.gresource --sourcedir /tmp/ports/usr/ports/x11-themes/greybird-theme/work/Greybird-3.23.3/dark/gtk-4.0
../dark/gtk-4.0/gtk.gresource.xml: Error on line 1 char 1: Document must begin with an element (e.g. <book>).
[ 18% 10/11] /usr/local/bin/sassc -a -M -t compact ../dark/gtk-4.0/gtk-contained-dark.scss dark/gtk-4.0/gtk-dark.css
FAILED: dark/gtk-4.0/gtk-dark.css 
/usr/local/bin/sassc -a -M -t compact ../dark/gtk-4.0/gtk-contained-dark.scss dark/gtk-4.0/gtk-dark.css
Error: Invalid CSS after ".": expected 1 selector or at-rule, was "../../light/gtk-4.0"
        on line 1:1 of ../dark/gtk-4.0/gtk-contained-dark.scss
>> ../../light/gtk-4.0/gtk-contained-dark.scss
   ^
[ 27% 10/11] /usr/local/bin/sassc -a -M -t compact ../dark/gtk-4.0/gtk-contained-dark.scss dark/gtk-4.0/gtk.css
FAILED: dark/gtk-4.0/gtk.css 
/usr/local/bin/sassc -a -M -t compact ../dark/gtk-4.0/gtk-contained-dark.scss dark/gtk-4.0/gtk.css
Error: Invalid CSS after ".": expected 1 selector or at-rule, was "../../light/gtk-4.0"
        on line 1:1 of ../dark/gtk-4.0/gtk-contained-dark.scss
>> ../../light/gtk-4.0/gtk-contained-dark.scss
   ^
[ 36% 10/11] /usr/local/bin/glib-compile-resources ../dark/gtk-3.0/gtk.gresource.xml --target dark/gtk-3.0/gtk.gresource --sourcedir /tmp/ports/usr/ports/x11-themes/greybird-theme/work/Greybird-3.23.3/dark/gtk-3.0
[ 45% 10/11] /usr/local/bin/sassc -M -t compact ../light/gtk-4.0/gtk.scss light/gtk-4.0/gtk.css
...

houndci-bot · 2023-09-26T12:36:13Z

+@import 'colors';
+@import 'drawing';
+@import 'common';
+@import 'colors-public';


Prefer double-quoted strings

houndci-bot · 2023-09-26T12:36:13Z

+
+@import 'colors';
+@import 'drawing';
+@import 'common';


Prefer double-quoted strings

houndci-bot · 2023-09-26T12:36:13Z

+$variant: 'dark';
+
+@import 'colors';
+@import 'drawing';


Prefer double-quoted strings

houndci-bot · 2023-09-26T12:36:13Z

+
+$variant: 'dark';
+
+@import 'colors';


Prefer double-quoted strings

houndci-bot · 2023-09-26T12:36:13Z

+//   you need a subtle shade
+// - if you need to inverse a color function use the @if directive to match for dark $variant
+
+$variant: 'dark';


Prefer double-quoted strings

mathiascode · 2023-09-26T12:42:17Z

Thanks, but fail to build:

Any difference now? The changes should match the GTK 3 theme, unless I overlooked something.

rozhuk-im · 2023-09-26T13:07:33Z

No, same errors.
It does not expect ../../light/gtk-4.0/ in files.

rozhuk-im · 2023-09-26T14:40:39Z

/dark/gtk-3.0/gtk-contained-dark.scss - is a symlink, probably you also shold convert files from error messages to symlinks.

mathiascode · 2023-09-26T19:32:02Z

It uses symlinks in the same way as the GTK 3 theme, although I don't understand why they are failing. Everything builds correctly on my end.

Does the master branch work fine for you?

rozhuk-im · 2023-09-26T19:54:12Z

Master build ok for me.

/dark/gtk-4.0/gtk.gresource.xml is not symlink, it is regular file!
Look at houndci-bot messages, it mark dark/gtk-4.0/Gemfile as regular file with unusual content.
Probably all symlinks was converted to regular files while you play with git before push here.

rozhuk-im · 2023-09-28T17:52:03Z

Probably you have set core.symlinks = false
https://mirrors.edge.kernel.org/pub/software/scm/git/docs/git-config.html
fix: git config core.symlinks true

mathiascode · 2023-09-29T13:57:55Z

Probably you have set core.symlinks = false https://mirrors.edge.kernel.org/pub/software/scm/git/docs/git-config.html fix: git config core.symlinks true

It was not set, but I set it to true just in case.

It's a symlink according to GitHub, and also when cloning my branch:

rozhuk-im · 2023-09-29T18:12:27Z

Sorry, FreeBSD~s patch does not handle symlinks from git patch files.
I do manual symlinks creation.

Now error changed:

[  9% 10/11] /usr/local/bin/glib-compile-resources ../dark/gtk-4.0/gtk.gresource.xml --target dark/gtk-4.0/gtk.gresource --sourcedir /tmp/ports/usr/ports/x11-themes/greybird-theme/work/Greybird-3.23.3/dark/gtk-4.0
FAILED: dark/gtk-4.0/gtk.gresource 
/usr/local/bin/glib-compile-resources ../dark/gtk-4.0/gtk.gresource.xml --target dark/gtk-4.0/gtk.gresource --sourcedir /tmp/ports/usr/ports/x11-themes/greybird-theme/work/Greybird-3.23.3/dark/gtk-4.0
../dark/gtk-4.0/gtk.gresource.xml: Failed to locate “assets/bullet-symbolic.svg” in any source directory.

mathiascode · 2023-09-30T09:50:03Z

Sorry, FreeBSD~s patch does not handle symlinks from git patch files. I do manual symlinks creation.

Now error changed:

[  9% 10/11] /usr/local/bin/glib-compile-resources ../dark/gtk-4.0/gtk.gresource.xml --target dark/gtk-4.0/gtk.gresource --sourcedir /tmp/ports/usr/ports/x11-themes/greybird-theme/work/Greybird-3.23.3/dark/gtk-4.0
FAILED: dark/gtk-4.0/gtk.gresource 
/usr/local/bin/glib-compile-resources ../dark/gtk-4.0/gtk.gresource.xml --target dark/gtk-4.0/gtk.gresource --sourcedir /tmp/ports/usr/ports/x11-themes/greybird-theme/work/Greybird-3.23.3/dark/gtk-4.0
../dark/gtk-4.0/gtk.gresource.xml: Failed to locate “assets/bullet-symbolic.svg” in any source directory.

Did you symlink the assets directory?

rozhuk-im · 2023-10-01T03:40:52Z

Yes, this help fix build issue.
It installed, but probably some missed - xfce does not show that GTK4 supported and dino (GTK4) does not become dark.

houndci-bot reviewed Sep 9, 2023

View reviewed changes

mathiascode force-pushed the greybird-dark-gtk4 branch from 27c472c to 473c72c Compare September 26, 2023 12:36

houndci-bot reviewed Sep 26, 2023

View reviewed changes

Add GTK 4 variant of Greybird-dark

278bcc1

mathiascode force-pushed the greybird-dark-gtk4 branch from 473c72c to 278bcc1 Compare September 29, 2023 13:40

		@@ -0,0 +1 @@
		../../light/gtk-4.0/Gemfile No newline at end of file

		@@ -0,0 +1 @@
		../../light/gtk-4.0/_common.scss No newline at end of file

		@@ -0,0 +1 @@
		../../light/gtk-4.0/gtk-contained-dark.scss No newline at end of file

		@@ -0,0 +1 @@
		../../light/gtk-4.0/gtk-dark.scss No newline at end of file

		@@ -0,0 +1 @@
		../../light/gtk-4.0/gtk.scss No newline at end of file


		$variant: 'dark';

		@import 'colors';

Conversation

mathiascode commented Sep 9, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rozhuk-im commented Sep 25, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mathiascode commented Sep 26, 2023

Uh oh!

rozhuk-im commented Sep 26, 2023

Uh oh!

rozhuk-im commented Sep 26, 2023

Uh oh!

mathiascode commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rozhuk-im commented Sep 26, 2023

Uh oh!

rozhuk-im commented Sep 28, 2023

Uh oh!

mathiascode commented Sep 29, 2023

Uh oh!

rozhuk-im commented Sep 29, 2023

Uh oh!

mathiascode commented Sep 30, 2023

Uh oh!

rozhuk-im commented Oct 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mathiascode commented Sep 26, 2023 •

edited

Loading