Conversation
Comment on lines
+2
to
+3
| String carName; | ||
| int carSpeed; |
There was a problem hiding this comment.
Поля лучше пометить final, тем самым исключив возможность их модификации извне
|
|
||
| Scanner scanner = new Scanner(System.in); | ||
| Winner winner = new Winner(); | ||
| ArrayList<Car> carStorage = new ArrayList<>(); |
There was a problem hiding this comment.
От хранения массива машин и лишнего цикла при определении победителя можно избавиться, если при вводе данных сразу вычислять победителя и хранить его в отдельной переменной, тогда программа будет требовать меньше памяти и работать быстрее
| String carName = scanner.next(); | ||
| scanner.nextLine(); | ||
|
|
||
| while (true) { |
There was a problem hiding this comment.
Код для считывания скорости с ввода лучше вынести в отдельную функцию - код, разделённый на небольшие функции, легче читать, поддерживать и переиспользовать
|
|
||
| for (int i = 1; i <= carStorage.size(); i++) { | ||
| Car carElement = carStorage.get(i-1); // получаем объект автомобиль | ||
| newDistance = carElement.carSpeed*24; // высчитываем расстояние, которое пройдет автомобиль |
There was a problem hiding this comment.
Число 24 лучше вынести в константу с говорящим названием для повышения читабельности кода
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Создано консольное приложение
Note
Implements a minimal console program to collect car data, validate input, and determine the fastest car.
Carmodel to storecarNameandcarSpeedWinnerclass withcalculateWinnerto pick the car with max distance over 24 hours (speed * 24)Mainreplaced to prompt for 3 cars, validate integer speeds within (0, 250], build a list, compute, and print the winner (winner.winnerStr)Written by Cursor Bugbot for commit c1e8623. This will update automatically on new commits. Configure here.