feat: generate mirrors patch #12265
Merged
feat: generate mirrors patch #12265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanduur
force-pushed
the
feat-generate-mirrors-patch
branch
from
26fc654 to
33f9da5
Compare
shanduur
commented
Nov 21, 2025
| imageCacheServeCmdFlags.mirrors, | ||
| imageCacheServeCmdFlags.tlsCertFile != "" && imageCacheServeCmdFlags.tlsKeyFile != "", | ||
| ); err != nil { | ||
| development.Error("failed to generate Talos config patch for registry mirrors", zap.Error(err)) |
Member
Author
There was a problem hiding this comment.
This is not a fatal error, we don't want to crash image-cache server here, so just log it.
Upon starting a image cache server, attempt to generate patch for Talos. Signed-off-by: Mateusz Urbanek <[email protected]>
shanduur
force-pushed
the
feat-generate-mirrors-patch
branch
from
33f9da5 to
f1c04e4
Compare
frezbo
reviewed
Nov 24, 2025
| return err | ||
| } | ||
|
|
||
| const patchFile = "image-cache-mirrors-patch.yaml" |
Member
There was a problem hiding this comment.
should we make this configurable?
Member
Author
There was a problem hiding this comment.
Most of our patches are not configurable now. I want to change it at some point, but make it all at once.
frezbo
approved these changes
Nov 24, 2025
Member
Author
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon starting a image cache server, attempt to generate patch for Talos.
Signed-off-by: Mateusz Urbanek [email protected]