test: Add diffs and simplify flows #1525
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ag-eitilt
approved these changes
Mar 4, 2024
Collaborator
ag-eitilt
left a comment
ag-eitilt
left a comment
There was a problem hiding this comment.
I've not compared the removed code to its replacements in fine detail, but on the whole removing hacks is good progress.
tests/tests.wake
Outdated
Comment on lines
46
to
57
| makeExecPlan | ||
| ( | ||
| "diff", | ||
| "-u", | ||
| "--color", | ||
| actualFile.getPathName, | ||
| expectFile.getPathName, | ||
| ) | ||
| ( | ||
| expectFile, | ||
| actualFile, | ||
| ) |
Collaborator
There was a problem hiding this comment.
I wonder if it would be cleaner to have the cmdline and the visible files as separate defs inside this block? Definitely not a critical change, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wake test system has had hacky support for
wake-unitfor quite some time. This lead to basically having two nearly but not quite identical test subsystems. In preparing to add the lsp tests to CI I realized it was closer towake-unitthan the other integration tests so I either needed to further ingrain the hack or fully remove the hack.I went ahead and removed the hack but this does require that more binaries (including test ones) be bootstrapped. This will somewhat increase the default install size but that can be worked around if it ever becomes a burden.
This PR also resolves a long standing TODO to print out a diff of the expected vs actual stdout/stderr when a failure occurs which will making resolving failures much easier.
