Fix presence NOTIFY CSeq resets for BLF subscriptions after new year rollover#3056
Open
junction1153b wants to merge 1 commit into
Open
Fix presence NOTIFY CSeq resets for BLF subscriptions after new year rollover#3056junction1153b wants to merge 1 commit into
junction1153b wants to merge 1 commit into
Conversation
…ear rollover This change persists per-subscription NOTIFY CSeq state for SIP presence/BLF subscriptions instead of relying on the year-relative global presence CSeq generator. It prevents Polycom phones from receiving backwards NOTIFY CSeq values after Jan 1 rollover or FreeSWITCH restarts when subscription state is retained. It also rejects stale in-dialog SUBSCRIBE refreshes with 481 Subscription Does Not Exist when FreeSWITCH no longer has matching subscription state, allowing endpoints to create a clean new subscription dialog. A high-water guard retires subscriptions before CSeq exhaustion so long-lived dialogs do not repeat or wrap CSeq values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change persists per-subscription NOTIFY CSeq state for SIP presence/BLF subscriptions instead of relying on the year-relative global presence CSeq generator. It prevents Polycom phones from receiving backwards NOTIFY CSeq values after Jan 1 rollover or FreeSWITCH restarts when subscription state is retained.
It also rejects stale in-dialog SUBSCRIBE refreshes with 481 Subscription Does Not Exist when FreeSWITCH no longer has matching subscription state, allowing endpoints to create a clean new subscription dialog. A high-water guard retires subscriptions before CSeq exhaustion so long-lived dialogs do not repeat or wrap CSeq values.