chore!: Remove builder proposals flag #748
Conversation
|
|
|
|
dknopik
left a comment
dknopik
left a comment
There was a problem hiding this comment.
Hey Shane, thanks for the PR! Looks good, some notes below.
| #[clap( | ||
| long, | ||
| alias = "private-tx-proposals", | ||
| help = "If this flag is set, Anchor will query the Beacon Node for only block \ | ||
| headers during proposals and will sign over headers. Useful for outsourcing \ | ||
| execution payload construction during proposals.", | ||
| display_order = 0, | ||
| help_heading = FLAG_HEADER | ||
| )] | ||
| pub builder_proposals: bool, |
There was a problem hiding this comment.
To ensure that we do not break the CLI, we should (as a first step) only hide this option, and emit a warning on startup if it is supplied, notifying the user that it is deprecated.
| Err(err) => debug!( | ||
| %err, | ||
| "Unable to publish validator registrations to the builder network" | ||
| "Unable to publish validator registrations to the builder network. \ | ||
| This is expected if no relay is configured in your Beacon Node." |
There was a problem hiding this comment.
Ideally, we only debug log this if the error is in fact caused by this (and keep the error log if it is not). I think it should be possible to check this. For reference, here is the log emitted currently:
2025-12-03T13:39:11.456556Z WARN Unable to publish validator registrations to the builder network err=Some endpoints failed, num_failed: 1 http://localhost:5052/ => RequestFailed(ServerMessage(ErrorMessage { code: 500, message: "UNHANDLED_ERROR: BuilderMissing", stacktraces: [] }))
2 participants
Issue Addressed
Closes #746
Proposed Changes
--builder-proposalsCLI flagwarntodebugAdditional Info
Why this change:
In DVT, validator registrations require threshold signatures from multiple operators. If some operators had
--builder-proposalsdisabled, they wouldn't participate in signing registrations, potentially causing the registration to fail for the entire committeeUser impact:
Users who previously used
--builder-proposalswill see a CLI error when trying to use the flag