Introduce lazy API resource activation (lazyApiResource + LazyResource)#2201
Draft
Introduce lazy API resource activation (lazyApiResource + LazyResource)#2201
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
LazyResourceclass inproject/lazy-resource.tswhich wraps arunedResourceReturnand only activates the underlying resource on firstcurrentread orrefetchcall.lazyApiResourcetoProjectContextinproject/project-context.svelte.tswhich composes arunedresource with an activation gate (LazyActivation) and returns aLazyResourcethat triggers the API factory on demand;apiResourcenow defaults tolazywhen API is not yet available.parts-of-speech.svelte.tsto uselazyApiResourceso parts-of-speech are not fetched until needed.ShadcnProjectView.svelteto register the parts-of-speech service in project scope without forcing load.LazyApiResourceHarness.sveltetest helper used by tests.lazy-resource.test.tsandlazy-api-resource.browser.test.tsthat verify activation semantics and lazy fetch behavior.Testing
vitestunit tests includinglazy-resource.test.ts, which passed.lazy-api-resource.browser.test.ts(via the test harness), which passed and confirmed the API factory is not called on initialization and that data is loaded after the firstcurrentread.Codex Task