silx.gui.plot.PlotWidget: Added asinh scale for axes#4529
Conversation
|
The icons could be improved but I think this can be reviewed. @t20100 |
t20100
left a comment
t20100
left a comment
There was a problem hiding this comment.
Thanks for working back on this feature!
| ICON_XSCALE = "mdi.arrow-left-right" | ||
| ICON_LINEAR = "ph.line-segment-bold" | ||
| ICON_LOG = "mdi.math-log" | ||
| ICON_ASINH = "mdi6.math-sin" |
There was a problem hiding this comment.
arcsinh is not sin.
There's some colormap-norm-[arcsinh|linear|log]] is silx icons maybe they could be reused here
There was a problem hiding this comment.
can i combine qtawesome icons with silx icons?
There was a problem hiding this comment.
I would not expect so, but I don't know
There was a problem hiding this comment.
what about this, all silx icons again
EdgarGF93
force-pushed
the
rebuild_arcsinh_x_y
branch
from
3776266 to
7217f91
Compare
|
We decided to make the v3.0.0 release as soon as possible and as a consequence your PR will be merged after this release, so we'll have time to also implement the arcsinh axes in the OpenGL backend. |
t20100
left a comment
t20100
left a comment
There was a problem hiding this comment.
LGTM, I may rework this a bit while adding the OpenGL support.
|
|
||
|
|
||
| AxisScaleType = typing.Literal["linear", "log"] | ||
| AxisScaleType = typing.Literal["linear", "log", "asinh"] |
There was a problem hiding this comment.
matplotlib uses asinh but we use arcsinh for the colormap scaling... Would be best to use only one.
I propose to be consistent with matplotlib and use asinh and add support for this name in colormap scales (in another PR)
t20100
force-pushed
the
rebuild_arcsinh_x_y
branch
from
7217f91 to
99b357d
Compare
t20100
changed the title
asinh scale for axes
github-project-automation
Bot
moved this from In Progress
to Done
in June 2026 Silx dev week
2 participants
<Module or Topic>: <Action> <Summary>(see contributing guidelines)Continue from #4306