Remove gaps

src/schedlib/policies/sat.py

@@ -976,7 +976,6 @@ def seq2cmd(
 
         # remove overlap of noobs blocks with cal and wiregrid blocks
         noobs_blocks = core.seq_remove_overlap(noobs_blocks, cal_blocks, flatten=True)
-
         seq = core.seq_sort(core.seq_merge(cmb_blocks, cal_blocks, flatten=True))
         seq = core.seq_sort(core.seq_merge(seq, noobs_blocks, flatten=True))
 

src/schedlib/policies/stages/build_op.py

@@ -509,7 +509,9 @@ def merge_adjacent_blocks(self, seq, max_dt=dt.timedelta(minutes=60), min_dt=dt.
             combined_duration = (current.duration + previous.duration).total_seconds()
             max_combined_duration = (max_dt + min_dt).total_seconds()
             # if blocks were split from same block and are close in time
-            if current.tag == previous.tag and time_gap <= min_dt.total_seconds():
+            current_uid = current.tag.split(",")[1].split("-")[:-2]
+            previous_uid = previous.tag.split(",")[1].split("-")[:-2]
+            if current_uid == previous_uid and time_gap <= min_dt.total_seconds():
                 # don't merge blocks that are longer than the max length
                 if combined_duration <= max_combined_duration:
                     seq[i-1] = previous.extend_right(current.duration)
@@ -529,6 +531,7 @@ def apply(self, seq, t0, t1, state):
         # giving up
         n_reject = 0
         reject_list = []
+
         while True:
             if len(reject_list) > 0:
                 reject_block = reject_list.pop(0)
@@ -548,22 +551,6 @@ def apply(self, seq, t0, t1, state):
                     break
                 seq_ = seq_new
 
-                cmb_blocks = self.merge_adjacent_blocks([s['block'] for s in seq_ if s['block'].subtype == 'cmb'],
-                             dt.timedelta(seconds=self.policy_config.max_cmb_scan_duration))
-
-                seq_temp = []
-                cmb_index = 0
-                for s in seq_:
-                    if s['block'].subtype == 'cmb':
-                        if cmb_blocks[cmb_index] is not None:
-                            s = s.copy()
-                            s['block'] = cmb_blocks[cmb_index]
-                            seq_temp.append(s)
-                        cmb_index += 1
-                    else:
-                        seq_temp.append(s)
-
-                seq_ = seq_temp
             else:
                 logger.warning(f"round_trip: ir did not converge after {self.max_pass} passes, proceeding anyway")
 
@@ -666,6 +653,7 @@ def lower(self, seq, t0, t1, state):
                     pre_ops=b['pre'], post_ops=b['post'], in_ops=b['in'],
                     causal=not(b['priority'] == priority)
                 )
+
                 if len(ir) == 0:
                     logger.info(f"--> block {b['block']} has nothing that can be planned, skipping...")
                     continue
@@ -695,6 +683,24 @@ def round_trip(self, seq, t0, t1, state):
             core.seq_map(lambda b: b.block if b.subtype == IRMode.InBlock else None, ir),
             flatten=True
         )
+
+        trimmed_blocks_ = trimmed_blocks
+        cmb_blocks = self.merge_adjacent_blocks([b for b in trimmed_blocks_ if b.subtype == 'cmb'],
+                             dt.timedelta(seconds=self.policy_config.max_cmb_scan_duration))
+
+        trimmed_blocks_temp = []
+        cmb_index = 0
+        for b in trimmed_blocks_:
+            if b.subtype == 'cmb':
+                if cmb_blocks[cmb_index] is not None:
+                    b = cmb_blocks[cmb_index]
+                    trimmed_blocks_temp.append(b)
+                cmb_index += 1
+            else:
+                trimmed_blocks_temp.append(b)
+
+        trimmed_blocks = trimmed_blocks_temp
+
         # match input blocks with trimmed blocks: since we are trimming the blocks
         # each block in ir should match one or none of the trimmed blocks.
         # this assumes no splitting is done in lowering process, which can be supported
@@ -878,7 +884,6 @@ def _plan_block_operations(self, state, block, constraint,
         logger.debug(f"--> planning pre-block operations")
 
         state, pre_dur, _ = self._apply_ops(state, pre_ops, block=block)
-
         logger.debug(f"---> pre-block ops duration: {pre_dur} seconds")
         logger.debug(f"---> pre-block curr state: {u.pformat(state)}")
 

src/schedlib/quality_assurance/sun_safety_checker.py

@@ -284,7 +284,7 @@ def raise_failure(self, e, line, moves=None):
         out = self.sungod.get_sun_pos(t=self.cur_time)
         logger.info(f'Sun position at failure time {out}')
         logger.error('Sun-safe motions not solved!')
-        t = datetime.datetime.utcfromtimestamp(self.cur_time)
+        t = datetime.datetime.fromtimestamp(self.cur_time, datetime.UTC)
         l = line.strip('\n')
         logger.error(
             f"Error on Line {self.cmd_n} \'{l}\' at time {t.isoformat()}"