Skip to content

fix(hammers/jackhammer): docker no-TTY option capitalization - #517

Merged
tristpinsm merged 1 commit into
masterfrom
tpm/fix-tty
Sep 1, 2026
Merged

fix(hammers/jackhammer): docker no-TTY option capitalization#517
tristpinsm merged 1 commit into
masterfrom
tpm/fix-tty

Conversation

@tristpinsm

Copy link
Copy Markdown
Contributor

docker cares about case

@BrianJKoopman BrianJKoopman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, strange, the -h help shows it lowercase:

$ docker compose run -h
Flag shorthand -h has been deprecated, use --help
Usage:  docker compose run [OPTIONS] SERVICE [COMMAND] [ARGS...]

Run a one-off command on a service

Options:
      --build                       Build image before starting container
      --cap-add list                Add Linux capabilities
      --cap-drop list               Drop Linux capabilities
  -d, --detach                      Run container in background and print container ID
      --dry-run                     Execute command in dry run mode
      --entrypoint string           Override the entrypoint of the image
  -e, --env stringArray             Set environment variables
      --env-from-file stringArray   Set environment variables from file
  -i, --interactive                 Keep STDIN open even if not attached (default true)
  -l, --label stringArray           Add or override a label
      --name string                 Assign a name to the container
      --no-deps                     Don't start linked services
  -T, --no-tty                      Disable pseudo-TTY allocation (default: auto-detected)

What version of compose are you using?

@tristpinsm

Copy link
Copy Markdown
Contributor Author

this smurf server is using

cryo@smurf-so8-lat:~$ docker compose version
Docker Compose version v2.18.1

and expects a capitalized flag (fails with the lower-case version)

cryo@smurf-so8-lat:~$ docker compose run -h
Flag shorthand -h has been deprecated, please use --help

Usage:  docker compose run [OPTIONS] SERVICE [COMMAND] [ARGS...]

Run a one-off command on a service.

Options:
      --build                 Build image before starting container.
  -d, --detach                Run container in background and print container ID
      --dry-run               Execute command in dry run mode
      --entrypoint string     Override the entrypoint of the image
  -e, --env stringArray       Set environment variables
  -i, --interactive           Keep STDIN open even if not attached. (default true)
  -l, --label stringArray     Add or override a label
      --name string           Assign a name to the container
  -T, --no-TTY                Disable pseudo-TTY allocation (default: auto-detected).

@tristpinsm

Copy link
Copy Markdown
Contributor Author

apparently this was resolved in v5.3.0

@BrianJKoopman
BrianJKoopman self-requested a review September 1, 2026 20:33

@BrianJKoopman BrianJKoopman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm on 5.4.0. What a silly thing. Sorry to do this, but let's just go back to -T where it's invoked. I'll make an inline suggestion for the docstring.

Comment thread sodetlib/hammers/jackhammer.py Outdated
--no-tty / --no-TTY have been used inconsistently over the
course of docker version history so avoid that.
@tristpinsm

Copy link
Copy Markdown
Contributor Author

agreed, that makes the most sense (and this is a very silly thing)

@BrianJKoopman BrianJKoopman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tristpinsm
tristpinsm merged commit 8f9593b into master Sep 1, 2026
2 checks passed
@tristpinsm
tristpinsm deleted the tpm/fix-tty branch September 1, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants