fix(hammers/jackhammer): docker no-TTY option capitalization - #517
Merged
Conversation
msilvafe
approved these changes
Sep 1, 2026
BrianJKoopman
left a comment
Member
There was a problem hiding this comment.
Hmm, strange, the -h help shows it lowercase:
$ docker compose run -h
Flag shorthand -h has been deprecated, use --help
Usage: docker compose run [OPTIONS] SERVICE [COMMAND] [ARGS...]
Run a one-off command on a service
Options:
--build Build image before starting container
--cap-add list Add Linux capabilities
--cap-drop list Drop Linux capabilities
-d, --detach Run container in background and print container ID
--dry-run Execute command in dry run mode
--entrypoint string Override the entrypoint of the image
-e, --env stringArray Set environment variables
--env-from-file stringArray Set environment variables from file
-i, --interactive Keep STDIN open even if not attached (default true)
-l, --label stringArray Add or override a label
--name string Assign a name to the container
--no-deps Don't start linked services
-T, --no-tty Disable pseudo-TTY allocation (default: auto-detected)
What version of compose are you using?
Contributor
Author
|
this smurf server is using and expects a capitalized flag (fails with the lower-case version) |
Contributor
Author
|
apparently this was resolved in v5.3.0 |
BrianJKoopman
self-requested a review
September 1, 2026 20:33
BrianJKoopman
requested changes
Sep 1, 2026
BrianJKoopman
left a comment
Member
There was a problem hiding this comment.
Yeah, I'm on 5.4.0. What a silly thing. Sorry to do this, but let's just go back to -T where it's invoked. I'll make an inline suggestion for the docstring.
--no-tty / --no-TTY have been used inconsistently over the course of docker version history so avoid that.
tristpinsm
force-pushed
the
tpm/fix-tty
branch
from
September 1, 2026 20:38
81199ed to
60f9dbc
Compare
Contributor
Author
|
agreed, that makes the most sense (and this is a very silly thing) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker cares about case