fix(org): show impersonation session controls - #7675
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR extends the existing impersonation and expired-session controls to organization pages and adds regression coverage for impersonated-user rollout isolation.
Confidence Score: 5/5The PR appears safe to merge; the organization shell reuses controls whose dependencies are available globally and preserves impersonated-user access isolation. No actionable failures remain: provider requirements, stop/recovery navigation, route ancestry, shell sizing, and rollout identity behavior are consistent with the existing workspace implementation and covered by focused tests.
|
| Filename | Overview |
|---|---|
| apps/sim/app/o/[organizationId]/layout.tsx | Adds the established impersonation and session-expiry controls to the organization shell without changing its access boundary. |
| apps/sim/app/o/[organizationId]/layout.test.tsx | Covers ordinary and impersonated rendering, banner placement, and organization rollout denial. |
| apps/sim/lib/navigation/organization-rollout.test.ts | Verifies navigation and Search gates consistently evaluate the impersonated customer organization across rollout combinations. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
Session[Current session] --> OrgLayout[Organization layout]
OrgLayout --> Banner[Impersonation banner]
OrgLayout --> Expiry[Session-expiry recovery]
OrgLayout --> Context[Organization surface context]
Context --> Chrome[Organization sidebar and content]
Banner -->|Stop impersonating| Entry[Application entry]
Expiry -->|Session becomes stale| Login[Sign out, clear state, and open login]
Reviews (1): Last reviewed commit: "fix(org): show impersonation session con..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
83 focused tests pass, including both layouts, session expiry, and all combinations of organization Search rollout gates. App TypeScript, full lint, API validation, and the pre-ship audit suite pass.
Checklist