fix(agent): keep tool configuration collapsed by default - #7678
fix(agent): keep tool configuration collapsed by default#7678BillLeoutsakosvl346 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR moves Agent tool-row expansion from persisted workflow data into local editor state.
Confidence Score: 5/5The PR appears safe to merge, with no outstanding correctness, security, or repository-rule issues. No changes were made after the previous review. The earlier import-order thread was resolved, and the author’s explanation is correct: the active Biome configuration groups
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx | Moves disclosure state out of stored tool data, preserves row-local state across list mutations, and strengthens read-only rendering and accessibility. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/tool-input/tool-input-expansion.test.tsx | Adds focused component coverage for local expansion, persistence boundaries, list identity changes, search, preview, and locked behavior. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Stored[Stored tool configuration] --> Editor[ToolInput editor]
Editor -->|initial render| Collapsed[Rows collapsed]
User[User disclosure action] --> Local[Local expansion state]
Search[Active parameter search] --> Display[Temporary displayed expansion]
Local --> Display
Editor -->|tool parameter edit| Persisted[Persisted workflow data]
Local -. no persistence .-> Persisted
External[External tool-list replacement] --> Reset[Reset local expansion]
Reviews (2): Last reviewed commit: "fix(agent): keep tool configuration expa..." | Re-trigger Greptile
|
@greptile Please re-evaluate the import-order finding against the active biome.json package-group ordering and the explanation in the resolved thread. The implementation is unchanged. |
|
Screenshots — synthetic component preview Actual ToolInput component in an isolated browser harness, not full-app end-to-end screenshots. Existing tools start collapsed; opening one leaves the other collapsed. The unavailable badges are disconnected test fixtures, not a regression. Both tools collapsed: One tool expanded independently: |


Summary
Keep Agent tool configuration rows collapsed when opening the editor. Expansion is local UI state instead of persisted workflow data; existing
isExpandedvalues remain compatible but no longer control the editor.New configurable tools open for setup without closing other rows. Local choices follow duplicate rows through removal and reordering, while external tool-list replacements reset expansion safely. Search can still reveal the matching parameter. Row disclosure uses a native button, separate from its actions, and preview/locked fields remain read-only.
Type of Change
Testing
Checklist
Screenshots/Videos
Browser verification used synthetic fixture tools in an isolated component harness; no full-app screenshots are attached.