Skip to content

improvement(search): simplify personal integrations and source setup - #7693

Merged
TheodoreSpeaks merged 4 commits into
stagingfrom
codex/remove-your-accounts-link
Sep 10, 2026
Merged

improvement(search): simplify personal integrations and source setup#7693
TheodoreSpeaks merged 4 commits into
stagingfrom
codex/remove-your-accounts-link

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Make Integrations personal, with inline Connect, direct OAuth, and Disconnect available during indexing, failures, and reconnect states.
  • Remove the standalone personal Connected accounts page while preserving organization account administration and explicit invitation flows.
  • Open Drive, Gmail, and Calendar on Accounts, move extra sync configurations under Advanced, and replace vague setup and sync labels with concrete states.

Type of Change

  • Improvement

Testing

423 tests across 23 focused suites passed after merging staging. App/auth typechecks, repository lint, all 46 audits, block registry, and docs manifest checks passed. Verified the local Integrations and provider settings previews, including Drive's corrected setup state.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 10, 2026 12:47am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes the personal Connected accounts settings surface and redirects non-Search enrollment return actions to Sim’s canonical application entry.

  • Removes the account settings section, renderer, personal account component, and related React Query hooks.
  • Removes the “Your accounts” action from organization Integrations while retaining administrator source management and Slack onboarding actions.
  • Preserves scoped Search returns and changes other enrollment returns to /home.
  • Leaves contributors without a remaining UI for the retained owner-scoped reconnect and disconnect operations.

Confidence Score: 4/5

The PR should not merge until contributors retain a supported way to reconnect or disconnect credentials they personally contributed.

The routing and removed-hook changes are internally consistent, but deleting the sole personal management surface makes retained owner-scoped grant controls inaccessible to non-admin and former organization members.

Files Needing Attention: apps/sim/components/settings/navigation.ts, apps/sim/ee/credential-groups/components/personal-organization-accounts.tsx, apps/sim/hooks/queries/organization-accounts.ts

Important Files Changed

Filename Overview
apps/sim/components/settings/navigation.ts Removes Connected accounts from the account plane, leaving contributors without personal grant-management navigation.
apps/sim/ee/credential-groups/components/personal-organization-accounts.tsx Deletes the only UI for contributors to list, reconnect, and disconnect their organization-contributed credentials.
apps/sim/hooks/queries/organization-accounts.ts Removes personal account hooks and cache invalidations consistently, while the corresponding server operations remain.
apps/sim/app/credential-groups/enroll/[token]/page.tsx Preserves scoped Search returns and otherwise routes users through the canonical /home entry resolver.
apps/sim/app/o/[organizationId]/integrations/integrations.tsx Removes the personal accounts link while safely retaining administrator and Slack-specific actions.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Enrollment[Enrollment or reconnect] -->|Search access| Search[Scoped organization/workspace Search]
  Enrollment -->|Other return| Entry["/home application entry resolver"]
  Entry --> Product[Active organization or workspace]
  Contributor[Credential contributor] --> Removed[Personal account management removed]
  Admin[Organization administrator] --> OrgSettings[Organization connected-account settings]
Loading

Reviews (1): Last reviewed commit: "improvement(settings): remove personal c..." | Re-trigger Greptile

@@ -539,14 +533,6 @@ export const SETTINGS_SECTION_REGISTRY: readonly SettingsSectionRegistryEntry[]
order: 1,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Contributor controls become inaccessible

Removing the personal Connected accounts page eliminates the only UI that calls the retained owner-scoped reconnect and disconnect operations. Non-admin contributors, including contributors who no longer belong to the organization, cannot access organization account management. They can no longer revoke or repair their contributed credentials themselves, so those credentials may continue indexing or being used by workflows until an organization administrator intervenes.

@TheodoreSpeaks TheodoreSpeaks changed the title improvement(settings): remove personal connected accounts page improvement(search): simplify personal integrations and source setup Sep 10, 2026
@TheodoreSpeaks
TheodoreSpeaks merged commit 2bfb8b1 into staging Sep 10, 2026
31 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the codex/remove-your-accounts-link branch September 10, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant