improvement(search): simplify personal integrations and source setup - #7693
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR removes the personal Connected accounts settings surface and redirects non-Search enrollment return actions to Sim’s canonical application entry.
Confidence Score: 4/5The PR should not merge until contributors retain a supported way to reconnect or disconnect credentials they personally contributed. The routing and removed-hook changes are internally consistent, but deleting the sole personal management surface makes retained owner-scoped grant controls inaccessible to non-admin and former organization members. Files Needing Attention: apps/sim/components/settings/navigation.ts, apps/sim/ee/credential-groups/components/personal-organization-accounts.tsx, apps/sim/hooks/queries/organization-accounts.ts
|
| Filename | Overview |
|---|---|
| apps/sim/components/settings/navigation.ts | Removes Connected accounts from the account plane, leaving contributors without personal grant-management navigation. |
| apps/sim/ee/credential-groups/components/personal-organization-accounts.tsx | Deletes the only UI for contributors to list, reconnect, and disconnect their organization-contributed credentials. |
| apps/sim/hooks/queries/organization-accounts.ts | Removes personal account hooks and cache invalidations consistently, while the corresponding server operations remain. |
| apps/sim/app/credential-groups/enroll/[token]/page.tsx | Preserves scoped Search returns and otherwise routes users through the canonical /home entry resolver. |
| apps/sim/app/o/[organizationId]/integrations/integrations.tsx | Removes the personal accounts link while safely retaining administrator and Slack-specific actions. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Enrollment[Enrollment or reconnect] -->|Search access| Search[Scoped organization/workspace Search]
Enrollment -->|Other return| Entry["/home application entry resolver"]
Entry --> Product[Active organization or workspace]
Contributor[Credential contributor] --> Removed[Personal account management removed]
Admin[Organization administrator] --> OrgSettings[Organization connected-account settings]
Reviews (1): Last reviewed commit: "improvement(settings): remove personal c..." | Re-trigger Greptile
| @@ -539,14 +533,6 @@ export const SETTINGS_SECTION_REGISTRY: readonly SettingsSectionRegistryEntry[] | |||
| order: 1, | |||
There was a problem hiding this comment.
Contributor controls become inaccessible
Removing the personal Connected accounts page eliminates the only UI that calls the retained owner-scoped reconnect and disconnect operations. Non-admin contributors, including contributors who no longer belong to the organization, cannot access organization account management. They can no longer revoke or repair their contributed credentials themselves, so those credentials may continue indexing or being used by workflows until an organization administrator intervenes.
Summary
Type of Change
Testing
423 tests across 23 focused suites passed after merging staging. App/auth typechecks, repository lint, all 46 audits, block registry, and docs manifest checks passed. Verified the local Integrations and provider settings previews, including Drive's corrected setup state.
Checklist