Skip to content

fix(search): omit response-only scopes from provider updates - #7707

Merged
icecrasher321 merged 1 commit into
stagingfrom
codex/search-provider-update-contract
Sep 10, 2026
Merged

fix(search): omit response-only scopes from provider updates#7707
icecrasher321 merged 1 commit into
stagingfrom
codex/search-provider-update-contract

Conversation

@icecrasher321

Copy link
Copy Markdown
Collaborator

Summary

  • Fix provider configuration updates failing when Slack is configured by omitting response-only scopes from the request.
  • Preserve saved scopes through the existing server update policy and verify the payload against the canonical contract.

Type of Change

  • Bug fix

Testing

  • 36 focused tests passed, including every supported provider with and without a custom Slack bot.
  • App type-check, lint, repository audits, and docs manifest checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 10, 2026 1:36am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because its payload now matches the strict update contract while the existing server merge policy preserves saved Slack scopes.

Summary

  • Removes requiredScopes from generated Slack update payloads.
  • Adds contract coverage for every standard provider and Slack configurations with and without a custom bot.
  • Strengthens service coverage to verify that stored scopes are restored for policy validation and persistence.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  UI[Provider settings UI] --> Helper[getOrganizationAccountUpdateOptions]
  Helper -->|ID, provider, label, required, bot ID| Contract[Strict update contract]
  Contract --> Service[Credential-group update service]
  Stored[(Stored option scopes)] -->|matched by option ID| Service
  Service --> Policy[Provider policy validation]
  Policy --> Persist[(Persist merged options)]
Loading

Reviews (1) · Last reviewed commit: "fix(search): omit response-only scopes f..."

@icecrasher321
icecrasher321 merged commit 73875ae into staging Sep 10, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-provider-update-contract branch September 10, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant