Skip to content

Conversation

@ryan-s
Copy link
Contributor

@ryan-s ryan-s commented Sep 12, 2023

Gitlab removed support for optionally expiring tokens in Gitlab 15.0. Adding in the refresh as optional since there may be self hosted instances in the wild older then 15.0.

https://docs.gitlab.com/ee/integration/oauth_provider.html#access-token-expiration

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #422 (a8d5bac) into main (27add75) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
+ Coverage   96.35%   96.36%   +0.01%     
==========================================
  Files          37       37              
  Lines        1070     1073       +3     
==========================================
+ Hits         1031     1034       +3     
  Misses         39       39              
Files Changed Coverage Δ
flask_dance/contrib/gitlab.py 96.00% <100.00%> (+0.54%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ryan-s
Copy link
Contributor Author

ryan-s commented Sep 13, 2023

Pinned pillow to 9.5 based on https://bugs.launchpad.net/tacker/+bug/2026345

@daenney
Copy link
Collaborator

daenney commented Sep 13, 2023

Pinned pillow to 9.5 based on https://bugs.launchpad.net/tacker/+bug/2026345

Ah, nice catch. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants