Update the action runtime from node20 to node24 - #1928
Merged
Conversation
Node 20 reached end-of-life on 2026-04-30. Bump the declared runtime and align everything that follows from it: - action.yml: runs.using node20 -> node24 - CI.yml: node-version 22 -> 24, so CI tests the runtime we ship on - vite.config.ts: set build.target explicitly instead of inheriting Vite's browser baseline - tsconfig.json: target es2022 -> es2023 Fixes #1926
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1928 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 218 218
Branches 57 57
=========================================
Hits 218 218 🚀 New features to boost your workflow:
|
Add engines.node >=24 so contributors on an older Node get a warning at install time rather than a confusing CI failure, and pin @types/node back to ^24 so the types match the runtime we ship on instead of describing APIs Node 24 does not have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1926.
Node 20 reached end-of-life on 2026-04-30, so the action was pinned to an unsupported runtime. This bumps the declared runtime and aligns everything that follows from it, so the runtime version is stated in one place and the build and CI follow it.
action.yml—runs.using: "node20"→"node24".github/workflows/CI.yml—node-version: 22→24, so CI builds and tests on the runtime the action actually executes onvite.config.ts— setbuild.target: "node24"explicitly, instead of inheriting Vite 8'sbaseline-widely-availablebrowser baseline (a browser constraint on a Node-only action, which would drift on every Vite major)tsconfig.json—target: "es2022"→"es2023"; Node 24 supports ES2023 in full, andlibis unset so it followstargetVerified locally:
npm run lint(eslint +tsc --noEmit) clean, 89/89 tests pass,node --check dist/index.jsparses. The rebuilt bundle is byte-identical to the committed one, sodist/is unchanged.