-
Notifications
You must be signed in to change notification settings - Fork 20
refactor!: rewrite markdown-templates/step-feedback/step-results-table.md to Nunjucks syntax, remove required top-level passed argument
#70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8ef44cc
refactor: modify templates to use nunjucks templating
FidelusAleksander fb1c81f
Merge branch 'main' into nunjucks-templates
FidelusAleksander 836c449
Work on whitespacing in nunjucks
FidelusAleksander dab9d99
Update finish exercise ref
FidelusAleksander e67d0a6
fix: update step-results-table to calculate all_passed based rows
FidelusAleksander 95f4650
Revert unnecessary changed files
FidelusAleksander bbd97d5
Revert unnecessary changed files
FidelusAleksander 6fdf693
Revert unnecessary changed files
FidelusAleksander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,39 @@ | ||
| {{#passed}} | ||
| {%- set all_passed = (results_table | selectattr("passed") | length) == (results_table | length) %} | ||
|
|
||
| {%- if all_passed %} | ||
|
|
||
| ## Step {{ step_number }} - Passed ✅ | ||
|
|
||
| {{/passed}} | ||
| {{^passed}} | ||
| {%- else %} | ||
|
|
||
| ## Step {{ step_number }} - Fail ❌ | ||
|
|
||
| {{/passed}} | ||
| {%- endif %} | ||
|
|
||
| {{#passed}} | ||
| {%- if all_passed %} | ||
| <img src="https://octodex.github.com/images/inflatocat.png" align="right" height="150px" alt="Inflatocat image indicating the step passed" /> | ||
| {{/passed}} | ||
| {{^passed}} | ||
| {%- else %} | ||
|
|
||
| <img src="https://octodex.github.com/images/spidertocat.png" align="right" height="100px" alt="Spidertocat image indicating the step failed" /> | ||
| Some checks failed. Please review the results below and try again. | ||
|
|
||
| Time to find the bug! 🤔 | ||
| {{/passed}} | ||
| {%- endif %} | ||
|
|
||
| | Status | Description | | ||
| | --- | --- | | ||
| {{#results_table}} | ||
| | {{#passed}}✅ - Pass{{/passed}}{{^passed}}❌ - Fail{{/passed}} | {{ description }} | | ||
| {{/results_table}} | ||
| | ------ | ----------- | | ||
|
|
||
| {{#tips.length}} | ||
| {%- for row in results_table %} | ||
| | {% if row.passed -%}✅ - Pass{%- else -%}❌ - Fail{%- endif %} | {{ row.description }} | | ||
| {%- endfor %} | ||
|
|
||
| {%- if tips and tips.length %} | ||
|
|
||
| ### Tips | ||
|
|
||
| {{#tips}} | ||
| {%- for tip in tips %} | ||
|
|
||
| - {{ tip }} | ||
| {%- endfor %} | ||
|
|
||
| - {{.}} | ||
| {{/tips}} | ||
| {{/tips.length}} | ||
| {%- endif %} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.