feat(update): single source of truth for the core binary set + uffs --update bins#447
Merged
Merged
Conversation
…--update bins` The UFFS core binary set was hardcoded in two places that could drift: `binaries::KNOWN_BINARIES` (Rust) and `BINS=(…)` in `just/build.just` (shell). Centralize on the Rust definition (now documented as the single source of truth — it already includes uffs-mft, so KNOWN ≡ the core set) and expose it to tooling via a new `uffs --update bins` action that prints the platform-appropriate stems (uffs-broker only on Windows), one per line. `just/build.just`'s `copy-binary` now queries `uffs --update bins` instead of keeping its own list, so adding/removing a core binary is a one-line change in one place and every flow picks it up. (`use-local` was already dynamic.) Host clippy (strict) clean; uffs-cli tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 17, 2026
githubrobbi
added a commit
that referenced
this pull request
Jun 17, 2026
… doc Dev-facing docs to match the user manual: - cli-grammar.md: add `repair` + `bins` to the `--update` action surface; note repair = doctor --repair alias, the doctor→update redirect, and that bare update reconciles the whole core set (adds a missing core binary). - UFFS-Self-Update-Feasibility-and-Design.md: add a §4.1 as-built addendum (action-based grammar) covering completeness (#447/#448), the repair verb + doctor redirect (#446/#449), and the journal to_version fix (#446). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
githubrobbi
added a commit
that referenced
this pull request
Jun 17, 2026
… issues (#449) * feat(update): doctor redirects to the update flow to fix update-class issues `uffs --update doctor` already diagnoses; now, when it finds an issue the update flow fixes — out of date, version-skewed, or **missing a core binary** — it redirects there instead of teaching the health-check helper the core set: - piped / non-TTY: prints a `→ run \`uffs --update\`` hint; - interactive TTY: asks "Run `uffs --update` now to fix this? [y/N]"; - `--repair` / `repair`: runs the update flow automatically (after the helper's local self-heal — resume/rollback, sweep backups, restart services). Keeps the architecture clean: the helper stays a dumb snapshot processor; the CLI (which owns the core set) decides what "incomplete" means and how to fix it. `--offline` skips the redirect (assess needs the release feed). The prompt never blocks a non-TTY caller — it returns "no" and falls back to the hint. Host clippy (strict) clean; uffs-cli tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs: note repair/bins actions + completeness in cli-grammar & design doc Dev-facing docs to match the user manual: - cli-grammar.md: add `repair` + `bins` to the `--update` action surface; note repair = doctor --repair alias, the doctor→update redirect, and that bare update reconciles the whole core set (adds a missing core binary). - UFFS-Self-Update-Feasibility-and-Design.md: add a §4.1 as-built addendum (action-based grammar) covering completeness (#447/#448), the repair verb + doctor redirect (#446/#449), and the journal to_version fix (#446). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foundation for the self-update completeness work (follow-up PR adds
missing-binary reconciliation; this one removes the drift risk first).
The core binary set was hardcoded in two places that could drift:
binaries::KNOWN_BINARIES(Rust)BINS=(uffs uffsd uffsmcp uffs-mft uffs-update)injust/build.just(shell)Changes
binaries::KNOWN_BINARIES(now documented as such;it already includes
uffs-mft, so KNOWN ≡ the core set — per the decision totreat the whole shipped suite as core).
uffs --update bins: new action that prints the platform-appropriate corestems (one per line;
uffs-brokeronly on Windows) — the machine-readableaccessor for tooling.
just/build.justcopy-binarynow queriesuffs --update binsinstead ofkeeping its own list. (
use-localwas already dynamic.)So adding/removing a core binary is a one-line change in one place, and every
flow (detection, deploy recipes, and the upcoming update-completeness) honours it.
Host clippy (strict) clean; uffs-cli tests pass;
uffs --update binsverified(5 stems on macOS, +
uffs-brokeron Windows).