Add getSemanticHTML options & Add preserveWhitespace option to getSem… #4598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is the best solution for the problem and is future proof due to extensibility. |
|
Would love to see this PR approved, just like many others we are having troubles with the |
|
This is quite good. Would you mind creating a PR to this repo: https://github.com/vincentdchan/quill-next Because the official Quill repository isn't active, I created a fork and have been maintaining it. Please take a look. If you submit a PR to my repository, I'll be happy to merge it! |
|
@vincentdchan based on what information you do assume this repo is not active? I'd like to know and potentially kick off a discussion |
|
@jankapunkt I think it ready has discussions about it. You can check this #4622 #4636 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As many people, I was also using quill for it HTML content, so it can be displayed somewhere else.
The addition of conversion from whitespace to
was needed for consecutive copying and pasting, so my proposition is to add options object that can be extended for other cases. For now, I addedpreserveWhitespacethat preserve all whitespaces if true, otherwise all whitespaces are changed to (default: false).I hope that this can be a middle ground between pushing Quill forward and providing compatibility for all people using it for a long time.