-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Algebrakit-ShadowDom support #4688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi! Thank you for this big work! |
|
Shadow DOM is a web standard to isolate web components. Anyone who develops web components for reuse in 3rd party websites (should) use Shadow DOM to prevent cross-over of CSS styling (for example). To be clear: This update does not introduce a Shadow DOM. It just ensures Quill functions correctly when used within a container with Shadow DOM. |
|
Got it! Thank you for your explanations and your work) |
We need this as well. I tried to use your fork in an angular application and got hit with a bunch of typescript errors. Can you provide a bit more info on how you installed and got your fork working? |
|
Hi @jessehouchins, I am using typescript 4.9.3 What are the errors you are getting? |
|
I had something messed up with my node modules. At one point I got it to build by adding |
|
@algebrakit I noticed the toolbar buttons are not highlighting for me when used in shadow dom... |
|
Ignore me... turns out this was a bug in our custom CSS and not related to this PR |
|
I have tested this in the following browsers and all seem to be working well:
|
|
Noticed that I can no longer drag images into the editor with this (in shadow dom). Copy/paste still works. |
|
Hi @jessehouchins, the relevant changes for shadow dom support are in packages/quill/src/core/dom-root.ts. I expect drag & drop can be added there as well. |
|
Thanks for the big effort! For our project we also need Quill to work in the shadow dom. Can someone give me an idea of when/if I can expect this PR to be merged into main? |
Unfortunately the main authors don't care about the project, so fork it yourself and work on Quill. They'll come back someday and you can contribute. |
|
sorely needing this, too... |


Make Quill work inside a container with shadow DOM enabled.
packages/quill/src/core/dom-root.tsTested in Chrome and Safari on a Mac.