Skip to content

chore: replace requirements.txt with pyproject.toml dependencies #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwbrooks merged 6 commits into from
Oct 19, 2026
Merged

chore: replace requirements.txt with pyproject.toml dependencies #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8fe2867
feat: update pyproject.toml with project section
mwbrooks Feb 20, 2026
20f74ab
Merge branch 'main' into mwbrooks-pyproject-project-section
WilliamBergamin May 11, 2026
3fa12f4
Merge branch 'main' into mwbrooks-pyproject-project-section
zimeg Aug 5, 2026
30b63e8
Merge branch 'main' into mwbrooks-pyproject-project-section
WilliamBergamin Oct 16, 2026
5b053ff
Merge branch 'main' into mwbrooks-pyproject-project-section
WilliamBergamin Oct 19, 2026
3f638f7
chore: replace requirements.txt with pyproject.toml dependencies
mwbrooks Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Install dependencies
run: |
pip install -U pip
pip install -r requirements.txt
pip install -e ".[dev]"
- name: Lint and check formatting
run: |
ruff check .
Expand All @@ -44,7 +44,7 @@ jobs:
- name: Install dependencies
run: |
pip install -U pip
pip install -r requirements.txt
pip install -e ".[dev]"
- name: Run all tests
run: |
pytest . -v
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ source .venv/bin/activate # for Windows OS, .\.venv\Scripts\Activate instead sh
#### Install dependencies

```sh
pip install -r requirements.txt
pip install -e ".[dev]"
```

</details>
Expand Down
17 changes: 17 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
[project]
name = "bolt-python-starter-template"
version = "0.0.0"
requires-python = ">=3.11"

@mwbrooks mwbrooks Feb 20, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I went with 3.11 because it's the min version our Workflow tests.

@WilliamBergamin WilliamBergamin Aug 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably use the latest version of python here and in the workflow tests

@mwbrooks mwbrooks Oct 19, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. 3.15?

@mwbrooks mwbrooks Oct 19, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second look, #93 already added 3.15 to the CI test matrix, so we're testing against the latest. I kept requires-python = ">=3.11" because raising it to 3.15 would block installs on the 3.11-3.14 versions CI still tests.

dependencies = [
"slack-bolt==1.30.0",
]

[project.optional-dependencies]
dev = [
"pytest==9.1.1",
"ruff==0.16.9",
]
Comment on lines +9 to +13

@zimeg zimeg Feb 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓 question: Can we remove requirements.txt alongside these additions?

IIRC the pyproject.toml is recommended as standard for dependencies?

It’s important to be clear that pip determines package dependencies using the project metadata (typically in pyproject.toml or setup.py), not by discovering requirements.txt files embedded in projects.

🔗 https://pip.pypa.io/en/latest/user_guide/#requirements-files

@WilliamBergamin WilliamBergamin Feb 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

➕

@mwbrooks mwbrooks Oct 19, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I think it's safe to remove the requirements.txt.

@mwbrooks mwbrooks Oct 19, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit 3f638f7


[tool.setuptools.packages.find]
include = ["listeners*"]

[tool.ruff]
line-length = 125
exclude = [".venv", "venv"]
Expand Down
3 changes: 0 additions & 3 deletions requirements.txt
View file
Open in desktop

This file was deleted.

Loading