feat(socket-mode): support undici v8 as a peer dependency - #2694
Open
WilliamBergamin wants to merge 6 commits into
Open
feat(socket-mode): support undici v8 as a peer dependency#2694WilliamBergamin wants to merge 6 commits into
WilliamBergamin wants to merge 6 commits into
Conversation
Widen the `undici` peer dependency range to `^7.0.0 || ^8.0.0` so consumers can bring either major. undici v8 requires Node >=22.19, while v7 continues to support Node >=20 — the source needs no changes, as v8 preserves every API socket-mode uses. CI now pairs each Node version with an undici major via a `versions` matrix and forces the socket-mode workspace onto that major before running the suite, so v8 support is actually exercised on capable Node versions. A new guardrail test asserts the Node/undici pairing (and never allows v8 on Node <22.19). Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
🦋 Changeset detectedLatest commit: 42ac8ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2694 +/- ##
=======================================
Coverage 89.14% 89.14%
=======================================
Files 65 65
Lines 10361 10361
Branches 473 473
=======================================
Hits 9236 9236
Misses 1094 1094
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
WilliamBergamin
added
tests
WilliamBergamin
marked this pull request as ready for review
August 10, 2026 18:58
Reduce the undici peer-dependency test to its two assertions, drop the comment essays and the general-purpose version-comparison helper in favor of a plain Node major check, and rename SOCKET_MODE_EXPECT_UNDICI_MAJOR to SOCKET_MODE_UNDICI_VERSION. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Contributor
Author
|
@zimeg I'll need to update the status checks if we want to merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expand
@slack/socket-modeto support bothundici@^7andundici@^8as a peer dependency.peerDependencies.undicito^7.0.0 || ^8.0.0. The source needs no logic changesversions: [{ node, undici }]matrix and forces the socket-mode workspace onto that major before running the suite.Requirements