-
Notifications
You must be signed in to change notification settings - Fork 846
feat(web-api): add slackLists methods #1772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1772 +/- ##
==========================================
- Coverage 85.15% 84.54% -0.62%
==========================================
Files 115 115
Lines 13068 12543 -525
==========================================
- Hits 11128 10604 -524
+ Misses 1940 1939 -1 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work working on this 💯
Would it be simple to add integration tests in integration_tests/web for these endpoints?
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srtaalej Thanks so much for bringing these methods to the SDK! 🧰 ✨
I'm finding good responses from the server when using these changes so am hoping we can merge this soon, but also left comments around typing that I think are worth consideration.
Overall I'm hoping we can improve our models here in the SDK to expect the various list item schemas, similar to Block Kit. This might not be a blocker for python releases, but we might require such for java and I do think we should aim to keep SDKs aligned in featureset when possible!
Lots of rambles. Please let me know if the other comments seem alright! 👾
|
|
||
|
|
||
| class TestWebClientCoverage(unittest.TestCase): | ||
| # 295 endpoints as of September 17, 2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏷️ note: We should update this as well!
Co-authored-by: Eden Zimbelman <[email protected]>
Summary
This PR adds the following
slackListsmethods to theslack_sdk:access.delete,access.set,create,download.get,download.start,items.create,items.delete,items.deleteMultiple,items.info,items.list,items.update,updateTesting
Category
Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.