internal/libs/asynclib: respect context deadline in WaitForAllNoErrOperations #1498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
Described in detail in the ticket. The short summary of it is that the plugin seems to hang for some nops in the chainfee.Processor's Observation method, which causes the entire observation to hang forever.
This causes participation to drop and alerts to fire. Other than that, we lose a participant in the DON which is not good.
The Solution
The plugin simply cannot allow Observation to hang for any reason; in order to achieve this, this PR updates the way WaitForAllNoErrOperations works:
ExecuteAsyncOperationswhich always respects the provided timeout - it abandons running goroutines that don't return within this timeout if necessaryWrapWithSingleFlightthat checks async.Mapobject prior to trying to run an operation again.ExecuteAsyncOperationsreturns prior to all goroutines finishing, the operation now returns a value instead of updating a value in a closure.