Skip to content

Conversation

@erikburt
Copy link
Contributor

@erikburt erikburt commented Dec 12, 2025

Changes

  • Analyze all changed modules dynamically via changed-modules-go/v1 and apidiff-go/v2

Notes

This is a step towards being able to recommend versions for these modules.

Also v2 addresses 3 formatting problems:

  • Remove bolded types (DX-2308)
  • Better handling for trailing commas with new function parameters (DX-2304)
  • Include compatible changes in PR comment (DX-2305)

New Behaviour

  • This will run against every module that has changed, not only root
  • Comments on PRs will be separate on a per-module basis

Example

  1. No modules changed (this PR): https://github.com/smartcontractkit/chainlink-common/actions/runs/20183018286/job/57947430245?pr=1734
  2. 2 modules changed:

DX-2304, DX-2305, DX-2308

@erikburt erikburt mentioned this pull request Dec 12, 2025
@erikburt erikburt requested a review from jmank88 December 12, 2025 23:51
@erikburt erikburt marked this pull request as ready for review December 12, 2025 23:51
@erikburt erikburt requested a review from a team as a code owner December 12, 2025 23:51
Copilot AI review requested due to automatic review settings December 12, 2025 23:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the API diff workflow to v2, enabling dynamic analysis of all changed Go modules rather than just the root module. The workflow now uses changed-modules-go/v1 to detect which modules have changes and runs apidiff-go/v2 against each one separately, with improved formatting and support for compatible changes in PR comments.

Key changes:

  • Added a new changed-modules job to dynamically detect modules with changes using file patterns for Go files and modules
  • Converted the single root-module job into a matrix-based analyze-api-changes job that runs per changed module
  • Updated actions to newer versions (checkout@v5, apidiff-go/v2) with adjusted configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant