Fix: use hex for transaction digest in events #257
Conversation
|
👋 faisal-chainlink, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
do you need to update only e2e tests in core or you need to update some actual logic in core? |
The actual core logic. Primarily just the part that reads the tx digest part of the events to state machine changes / transaction state signals in core. |
* allow maxRetries instead of maxRetries - 1 * avoid overwriting the module name in event selector when querying for events
* firedrill contracts test * add firedrill sanity check * extend configs to allow overriding event offset * add an offset override fallback for events * remove unnecessary unlock
…led transactions from transmitters
* update event indexer and txn indexer to insert txDigest as a hex string * fix bug related to events cursor txDigest * update events indexer test * tidy * block hash base58 * Misc fixes (#274) * allow maxRetries instead of maxRetries - 1 * avoid overwriting the module name in event selector when querying for events * update tests to skip if the DB url is not provided * update txm confirmer test * edit error logs * Enhancement/allow override event offset (#295) * firedrill contracts test * add firedrill sanity check * extend configs to allow overriding event offset * add an offset override fallback for events * remove unnecessary unlock * ensure base58 instead of hex when parsing block and tx digest in transaction indexer * cleanup logs * search SourceChainConfigSet using strings instead of u64 for chain selectors * add a database table to store transactions cursors when replaying failed transactions from transmitters * disable firedrill sanity test --------- Co-authored-by: Sishir Giri <[email protected]> Co-authored-by: FelixFan1992 <[email protected]>
3 participants
The E2E tests for this are expected to fail until core is updated to handle the hex tx digest instead of bytes.