Feat: Add a coin reservation abstraction to prevent equivocation within the same relayer #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 faisal-chainlink, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
stackman27
reviewed
Dec 25, 2025
stackman27
reviewed
Jan 1, 2026
FelixFan1992
approved these changes
Jan 1, 2026
faisal-chainlink
added a commit
that referenced
this pull request
Jan 5, 2026
…in the same relayer (#304) * add a GasCoinManager abstraction * add locked coin error parsing to reserve coins * allow setting an expiry when reserving coins * update GasCoinManager * fix txm tests * release coins on confirmer marking transaction as failed or succeeded * error checking * add separate txm error strategy for simple coin refreshing (used for locked coins) * nit --------- Co-authored-by: stackman27 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR includes the following:
GasCoinManagerabstraction to keep a cache of "reserved" coins (being used in other transacitons)Additional description of the change
For a tx we build/send, you reserve its payment coins by calling
TryReserveCoins(txID, []SuiObjectRef, expiry=nil)(or similar). That creates:coinID -> truewith TTL = 30s (default)txID -> []SuiObjectRefwith TTL = 30sIf we then detect the “locked coin / equivocation” issue and run the quarantine path, you call
TryReserveCoins(..., &expiry)with 24h, which creates:coinID -> truewith TTL = 24htxID -> []SuiObjectRefwith TTL = 30s (still)So after ~30s or failure/success:
That’s why later ReleaseCoins(txID) often can’t undo the 24h quarantine: it loses the txID→coins index, but the coin lock key is still present.