[GS-5825]/provide support for typescript_Engineering Ticket #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PranitaJainB
commented
Feb 20, 2025
PranitaJainB
requested review from
JBezerra,
conraddavisjr,
positiveVibes4all and
sandhya-spend
sandhya-spend
requested changes
Feb 27, 2025
Contributor
sandhya-spend
left a comment
sandhya-spend
left a comment
There was a problem hiding this comment.
tsxandtypescriptshould be added topackage.jsonso that they are setup during install. Alsoconcurrently.- Also, cannot run certain commands.
Contributor
Author
Done. |
Contributor
sandhya-spend
requested changes
Mar 3, 2025
Contributor
sandhya-spend
left a comment
sandhya-spend
left a comment
There was a problem hiding this comment.
[Blocker[ All the tsconfig.json fles are pretty much the same. Consolidate them all to tsconfig.all.jsonc and have only the differting options and extends.
PranitaJainB
changed the title
stellarhoof
previously requested changes
Mar 10, 2025
Contributor
|
Coverage after merging GS-5825/support-for-typescript into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
stellarhoof
reviewed
Apr 21, 2025
| "@changesets/cli": "^2.26.0", | ||
| "@flex-development/toggle-pkg-type": "^1.0.1", | ||
| "@vitest/coverage-v8": "^2.1.1", | ||
| "concurrently": "^9.1.2", |
Member
There was a problem hiding this comment.
blocker: This package is not being used so it can be removed.
| "glob": "^8.1.0", | ||
| "minimist": "^1.2.7", | ||
| "prettier": "^2.8.3", | ||
| "tsx": "^4.19.3", |
Member
There was a problem hiding this comment.
blocker: This package is not being used so it can be removed.
Member
|
Some feedback is still outstanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jira
GS-5825
Requirement
Contexture has never been user friendly, which is compounded by the fact that there is little documentation and no types. This ticket aims to add TypeScript support to it in order to make it more understandable and usable.
NOTE: This ticket is only about enabling TypeScript, not typing the code!
Verifying
I am testing by renaming a file
packages/client/src/listeners.jsto .ts extension . After that I ran a commandtsc --noEmitat client folder , and it starts giving Typescript error .