Fix static analysis errors in Data class method chaining #1166
+7
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1143
This PR resolves static analysis errors when using method chaining.
The
Smartyclass extends theDataclass, but the PHPDoc return types for methods in theDataclass (assign(),append(), etc.) were documented as returningData.As a result, when using method chaining like the following, static analysis tools would interpret that a
Datainstance is returned instead of aSmartyinstance, and would report errors thatSmarty-specific methods (e.g.,display()) do not exist.I changed the PHPDoc return type from Data to $this. By using $this, static analysis tools can correctly recognize that an instance of the actually invoked class (in this case, Smarty) is returned.
This change only modifies PHPDoc comments and has no effect on runtime behavior.