Skip to content

fix triple pojo overload issue #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EvenLjj wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix triple pojo overload issue #1523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion remoting/remoting-triple/src/main/java/com/alipay/sofa/rpc/utils/SofaProtoUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ public static Map<String, String> cacheStreamCallType(Class proxyClass) {
for (Method method : declaredMethods) {
String streamType = mapStreamType(method);
if (StringUtils.isNotBlank(streamType)) {
methodCallType.put(method.getName(), streamType);
if (methodCallType.putIfAbsent(method.getName(), streamType) != null) {
throw new SofaRpcException(RpcErrorType.UNKNOWN, "triple pojo stream do not support method overload!!!");
}
Comment on lines +103 to +105
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use consistent error type and improve error message quality.

The validation logic correctly prevents method overloads, but there are two issues:

  1. Inconsistent error type: This validation uses RpcErrorType.UNKNOWN, while similar call-type validations elsewhere in this file (lines 92, 126, 134) use RpcErrorType.CLIENT_CALL_TYPE. For consistency, this should also use CLIENT_CALL_TYPE.

  2. Error message quality: The message has grammatical issues ("stream do not" → "streaming does not") and excessive exclamation marks. Consider a more professional message like: "Triple POJO streaming does not support method overloads"

Apply this diff to address both issues:

-                if (methodCallType.putIfAbsent(method.getName(), streamType) != null) {
-                    throw new SofaRpcException(RpcErrorType.UNKNOWN, "triple pojo stream do not support method overload!!!");
-                }
+                if (methodCallType.putIfAbsent(method.getName(), streamType) != null) {
+                    throw new SofaRpcException(RpcErrorType.CLIENT_CALL_TYPE, 
+                        "Triple POJO streaming does not support method overloads");
+                }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if (methodCallType.putIfAbsent(method.getName(), streamType) != null) {
throw new SofaRpcException(RpcErrorType.UNKNOWN, "triple pojo stream do not support method overload!!!");
}
if (methodCallType.putIfAbsent(method.getName(), streamType) != null) {
throw new SofaRpcException(RpcErrorType.CLIENT_CALL_TYPE,
"Triple POJO streaming does not support method overloads");
}
🤖 Prompt for AI Agents 
In
remoting/remoting-triple/src/main/java/com/alipay/sofa/rpc/utils/SofaProtoUtils.java
around lines 103 to 105, the exception uses RpcErrorType.UNKNOWN and an
unpolished message; change the error type to RpcErrorType.CLIENT_CALL_TYPE to
match other call-type validations and replace the message with a professional
sentence such as "Triple POJO streaming does not support method overloads"
(remove extra punctuation and fix grammar).

}
}
return methodCallType;
Expand Down
Loading