Feat/foreground service notifications #802
Conversation
…re-mansion/react-native-audio-api into feat/fs_android_recording
michalsek
left a comment
michalsek
left a comment
There was a problem hiding this comment.
Small nitpicks, but overall great job, thanks for this! :)
| ## Example | ||
|
|
||
| ```tsx | ||
| // TO DO |
| ## Example | ||
|
|
||
| ```tsx | ||
| // TODO |
| fun setLockScreenInfo(info: ReadableMap?) { | ||
| lockScreenManager.setLockScreenInfo(info) | ||
| // No-op: Old system removed | ||
| } |
There was a problem hiding this comment.
why we want to keep them even when they do nothing?
| if (notificationId != -1 && notificationKey != null) { | ||
| startForegroundService(notificationId, notificationKey) | ||
| } else { | ||
| Log.w(TAG, "Invalid notification data received") |
There was a problem hiding this comment.
nit: log id and key? instead of data -> might be misleading towards invalid payload
| .Builder(context, channelId) | ||
| .setSmallIcon(android.R.drawable.ic_btn_speak_now) | ||
| .setContentTitle(title) | ||
| .setContentText("Ready to record") |
There was a problem hiding this comment.
| .setContentText("Ready to record") | |
| .setContentText(description) |
| unregisterReceiver() | ||
|
|
||
| // Reset state | ||
| title = "Audio Recording" |
There was a problem hiding this comment.
| title = "Audio Recording" | |
| title = "Audio Recording" | |
| description = "Ready to record" |
if we want to really fully reset the user content
| notificationBuilder?.setColor(Color.RED) | ||
| notificationBuilder?.setColorized(true) | ||
| } else { | ||
| notificationBuilder?.setColorized(false) |
There was a problem hiding this comment.
could you add linear issue to make it configure'able some day?
| // dummy subscription object with a no-op remove method | ||
| return { | ||
| remove: () => {}, | ||
| } as any; |
There was a problem hiding this comment.
| } as any; | |
| } as unknown as AudioEventSubscription; |
this would get rid of any warning and as well as match the AudioEventSubscription type
| On iOS, this method clears the metadata but does not hide the notification controls. To completely hide controls on iOS, you must suspend or close the AudioContext. | ||
| ::: |
There was a problem hiding this comment.
This is sligthly invalid - notification can be dismissed by calling the (internal) .endReceivingRemoteControlEvents (or whatever is the exact name).
💀
Closes RNAA-310
TODO
Maybe TODO
NotificationReceiver for notification dissmised event can be centralized right now there are two receivers(not wanted)AudioManageryou should usePlaybackNotificationManagerIntroduced changes
RecordingNotificationManagerfor management of notification dedicated for recordingPlaybackNotificationManagerfor management of notification dedicated for playbackAudioManagerChecklist