Feat/delay node #803
Open
Feat/delay node #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vltkv
reviewed
Nov 13, 2025
vltkv
reviewed
Nov 13, 2025
poneciak57
approved these changes
Nov 13, 2025
vltkv
reviewed
Nov 13, 2025
vltkv
approved these changes
Nov 13, 2025
maciejmakowski2003
requested changes
Nov 14, 2025
packages/react-native-audio-api/common/cpp/audioapi/HostObjects/BaseAudioContextHostObject.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/DelayNode.cpp
Outdated
Show resolved
Hide resolved
maciejmakowski2003
requested changes
Nov 20, 2025
| if constexpr (std::is_base_of_v<AudioScheduledSourceNode, U>) { | ||
| return node.use_count() == 1 && (node->isUnscheduled() || node->isFinished()); | ||
| } else if constexpr (std::is_base_of_v<ConvolverNode, U>) { | ||
| } else if constexpr (std::is_base_of_v<ConvolverNode, U> || std::is_base_of_v<DelayNode, U>) { |
Collaborator
There was a problem hiding this comment.
lets add comment about the reason behind it.
Collaborator
There was a problem hiding this comment.
lets add requiresTailProcessing method to AudioNode instead of explicit class check
| static_cast<size_t>( | ||
| maxDelayTime * context->getSampleRate() + | ||
| 1), // +1 to enable delayTime equal to maxDelayTime | ||
| 2, |
Collaborator
There was a problem hiding this comment.
use channelCount property
| } | ||
| } | ||
|
|
||
| // delay buffer always has 2 channels, mix if needed |
Collaborator
There was a problem hiding this comment.
Suggested change
| // delay buffer always has 2 channels, mix if needed | |
| // delay buffer always has ${channelCount_} channels, mix if needed |
| } | ||
| auto delayTime = delayTimeParam_->processKRateParam(framesToProcess, context_->getCurrentTime()); | ||
| size_t processingBusStartIndex = 0; | ||
| size_t writeIndex = static_cast<size_t>(readIndex_ + delayTime * context_->getSampleRate()) % |
Collaborator
There was a problem hiding this comment.
Suggested change
| size_t writeIndex = static_cast<size_t>(readIndex_ + delayTime * context_->getSampleRate()) % | |
| auto writeIndex = static_cast<size_t>(readIndex_ + delayTime * context_->getSampleRate()) % |
| } | ||
|
|
||
| // delay buffer always has 2 channels, mix if needed | ||
| std::shared_ptr<AudioBus> DelayNode::processNode( |
Collaborator
There was a problem hiding this comment.
add comments about write/read process, separate each step with new line
poneciak57
approved these changes
Nov 21, 2025
michalsek
requested changes
Nov 21, 2025
| processingBus->sum(delayBuffer_.get(), readIndex_, 0, framesToProcess); | ||
| delayBuffer_->zero(readIndex_, framesToProcess); | ||
| readIndex_ += framesToProcess; | ||
| return processingBus; |
Member
There was a problem hiding this comment.
could you format the process method a bit? It is really hard to read when it is wall of text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RNAA-320
Introduced changes
DelayNodeChecklist