Feat/wave shaper #806
Open
Feat/wave shaper #806
+1,089
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
November 11, 2025 22:18
Collaborator
Author
|
example will be removed after review. |
mdydek
requested changes
Nov 26, 2025
|
|
||
| export interface IWaveShaperNode extends IAudioNode { | ||
| readonly curve: Float32Array | null; | ||
| oversample: OverSampleType; |
Contributor
There was a problem hiding this comment.
without import it defaults to web audio api type
Comment on lines
+46
to
+63
| ### `OverSampleType` | ||
|
|
||
| <details> | ||
|
|
||
| **Acceptable values:** | ||
| - `none` | ||
|
|
||
| Do not oversample. | ||
|
|
||
| - `2x` | ||
|
|
||
| Oversample two times. | ||
|
|
||
| - `4x` | ||
|
|
||
| Oversample four times. | ||
|
|
||
| </details> |
Contributor
There was a problem hiding this comment.
personally, I think pasting the typescript interface definition and commenting inside would me more readable and this is the approach in other examples
Comment on lines
+54
to
+55
| auto arrayBuffer = | ||
| args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime); |
Contributor
There was a problem hiding this comment.
typescript allow pass of null value, but you are not checking its existence and passing null, crashes the app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RNAA-344
Introduced changes
Checklist